[5.0] Guard method onceUsingId not returning false but throwing exception #8836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… call leading to an exception in onceUsingId instead of returning false if the provider for the specified ID returns null
| @@ -710,7 +710,7 @@ public function getUser() | |||
| * @param \Illuminate\Contracts\Auth\Authenticatable $user | |||
| * @return void | |||
| */ | |||
| public function setUser(UserContract $user) | |||
| public function setUser(UserContract $user = null) | |||
There was a problem hiding this comment.
You need to update the phpdoc.
GrahamCampbell
changed the title
|
I've updated the solution a little to not touch the setUser method but simply checking for a null value inside the onceUsingId. Setting the user property to null wouldn't make much sense imho unless it would behave like a logout. |
…ole method to fail if the provider doesn't return an instance implementing Illuminate\Contracts\Auth\Authenticatable
taylorotwell
added a commit
that referenced
this pull request
May 21, 2015
[5.0] Guard method onceUsingId not returning false but throwing exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Guard implementation not accepting a null value for the setUser call leading to an exception in onceUsingId instead of returning false if the provider returns null for the specified user ID.