[5.1] Auth::id() don't get $id from Recaller

[apollopy]

The id function note: Get the ID for the currently authenticated user.

if get id from remember cookie, the cookie may invalid.(If a user sign out in other browsers)

[GrahamCampbell]

Thanks, but I'm not quite sure what this fixes?

[GrahamCampbell]

Does it not break stuff?

[apollopy]

$this->getRecallerId() get user id from cookie，but it did not check whether the cookie's token is valid

[apollopy]

Code logic has not changed, just get the vaule from a trusted function

[taylorotwell]

Signing out in other browsers would have no effect on this browser's cookies.

[apollopy]

https://github.com/laravel/framework/blob/5.1/src/Illuminate/Auth/Guard.php#L550

First of all pls look at the link I post above.

Auth::logout() will refresh the Remember Token，which will lead to the remember cookie of other browsers invalid. This will result in the getUserByRecallercould not return to user in other browsers. according to the link

test:

browser A，session expired and remember cookie exist.

// browser A，session expired and remember cookie exist.
Auth::id(); // return 1
Auth::user(); // return user object by 1

If you firstly logout on browser B, then try to run the code on browser A in the same situation, it would not get the same result .

// browser B logout

// browser A，session expired and remember cookie exist.
Auth::id(); // return 1
Auth::user(); // return null

This is what I fixed:

// browser B logout

// browser A，session expired and remember cookie exist.
Auth::id(); // return null
Auth::user(); // return null

[taylorotwell]

OK will take a look.