[5.5] delete function id

[apollopy]

Because it's the same as https://github.com/laravel/framework/blob/5.5/src/Illuminate/Auth/GuardHelpers.php#L68

[browner12]

the function contents are different. how is this the same?

[apollopy]

read

https://github.com/laravel/framework/blob/5.5/src/Illuminate/Auth/SessionGuard.php#L112-L125

and

https://github.com/laravel/framework/blob/5.5/src/Illuminate/Auth/SessionGuard.php#L205-L207

public function id()
{
    if ($this->loggedOut) {
        return;
    }
    return $this->user()
        ? $this->user()->getAuthIdentifier()
        : $this->session->get($this->getName());
}

->

public function id()
{
    if ($this->loggedOut) {
        return;
    } else {
        if ($this->user()) {
            return $this->user()->getAuthIdentifier();
        } else {
            /**
             * This is superfluous.
             * if $this->loggedOut == false and can get by session,
             * $this->user() will return user object.
             * if $this->loggedOut == false and not can get by session,
             * $this->user() will get by "remember me" cookie or return null.
             */
            return $this->session->get($this->getName());
        }
    }
}

->

public function id()
{
    if ($this->loggedOut) { // This is superfluous, $this->user() Already judged
        return;
    } else {
        if ($this->user()) {
            return $this->user()->getAuthIdentifier();
        }
    }
}

->

/**
 * it's the same as
 * https://github.com/laravel/framework/blob/5.5/src/Illuminate/Auth/GuardHelpers.php#L68
 */
public function id()
{
        if ($this->user()) {
            return $this->user()->getAuthIdentifier();
        }
}

[apollopy]

#16373

After this pr, there is no practical significance.

[jmarcher]

They could do the same or not, but deleting a public method is a massive breaking change.

So big 👎

[apollopy]

This is not deleting. The id function exists in Traits GuardHelpers, and SessionGuard use GuardHelpers.

https://github.com/laravel/framework/blob/5.5/src/Illuminate/Auth/GuardHelpers.php#L68
https://github.com/laravel/framework/blob/5.5/src/Illuminate/Auth/SessionGuard.php#L20

The current class override Trait methods, try not to get the User object from the database, only get id from session. But brought a lot of bugs:

this #13769 and this #16373

After several fixed bugs, the original purpose no exists.
Either completely override the id function to the extent that there is no bug, or remove the override