[5.3] Use Carbon instead of time() #15544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it-can
reviewed
Sep 21, 2016
| @@ -77,7 +78,7 @@ public function get($key) | |||
| $cache = (object) $cache; | |||
| } | |||
|
|
|||
| if (time() >= $cache->expiration) { | |||
| if (Carbon::now()->timestamp >= $cache->expiration) { | |||
There was a problem hiding this comment.
why not use getTime() function here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in this issue: #14253
Carbon library has a very useful and easy to use feature to travel in time inside tests:
Since Carbon is a current dependency in laravel, this PR replaces all calls to php's built in
time()function and uses Carbon instead, allowing tests to "Time Travel".