New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.3] Directly use getTimestamp() #15549

Merged

taylorotwell merged 1 commit into laravel:5.3 from lucasmichot:feature/5.3/getTimestamp

Sep 22, 2016

Contributor

lucasmichot commented Sep 21, 2016 •

edited

Loading

Each time we access \Carbon\Carbon::$timestamp, we are in fact calling the magic \Carbon\Carbon::__get function: https://github.com/briannesbitt/Carbon/blob/master/src/Carbon/Carbon.php#L607-L660

This PR gets rid of this useless intermediary call.

Related to #15544 / Ping @themsaid


          Always use getTimestamp()

417151f

taylorotwell merged commit 70bf117 into laravel:5.3

lucasmichot deleted the feature/5.3/getTimestamp branch

September 22, 2016 15:06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet