[5.4] All tests have been namespaced #17148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small conflict has arisen due to #17165 I will fix and push this this evening. |
GrahamCampbell
changed the title
|
Had to force push for the rebase. |
|
@taylorotwell Please can you clarify on any issues you have on this? I have a fair few plans for future test improvement PRs, that require autoloading and namespaced tests. |
|
YAY! Thanks taylor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite a lot of patching has happened to make tests continue to pass. This all consists of making the expected values, or mocked values have their own namespace. The content of the tests has not changed.