Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.4] Use ::class notation in tests #17518

Closed
wants to merge 22 commits into from
Closed

[5.4] Use ::class notation in tests #17518

wants to merge 22 commits into from

Conversation

lucasmichot
Copy link
Contributor

Use ::class notation in tests.

See #17357 and #17148 by @alexbowers

Notes:

  • This PR only apply to /tests code.
  • All FQN were let as it on purpose.

@lucasmichot
Use ::class notation for Auth
926eb6c
@lucasmichot
Use ::class notation for Bus
b60ada3
@lucasmichot
Use ::class notation for Cache
803acf7
@lucasmichot
Use ::class notation for Console
a55c3c8
@lucasmichot
Use ::class notation for Container
d728dd4
@lucasmichot
Use ::class notation for Cookie
665a1d6
@lucasmichot
Use ::class notation for Database
abf43b9
@lucasmichot
Use ::class notation for Events
8f19f27
@lucasmichot
Use ::class notation for Foundation
2ec2e68
@lucasmichot
Use ::class notation for Http
733e01b
@lucasmichot
Use ::class notation for Log
1dec2d2
@lucasmichot
Use ::class notation for Mail
8e1aa70
@lucasmichot
Use ::class notation for Notifications
975273f
@lucasmichot
Use ::class notation for Pipeline
01c496a
@lucasmichot
Use ::class notation for Queue
bf203ab
@lucasmichot
Use ::class notation for Session
35139c6
@lucasmichot
Use ::class notation for Session
fc625c8
@lucasmichot
Use ::class notation for Support
28b72b3
@lucasmichot
Use ::class notation for Translation
1f2ffb6
@lucasmichot
Use ::class notation for Validation
d33b337
@lucasmichot
Use ::class notation for View
309ac4c
@lucasmichot
Also replace StdClass
9f39f17
alexbowers
alexbowers approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@alexbowers alexbowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me :)

@taylorotwell
Copy link
Member

This is just a huge PR I can't look throught it right now :/

@lucasmichot lucasmichot deleted the feature/5.4/tests-class-notation branch February 8, 2017 19:42
@lucasmichot lucasmichot mentioned this pull request Jun 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbowers alexbowers alexbowers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasmichot @taylorotwell @alexbowers