[5.4] Add macros to Eloquent/Builder #17719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
pjona
reviewed
Feb 7, 2017
| * | ||
| * @throws \BadMethodCallException | ||
| */ | ||
| public static function __callStatic($method, $parameters) |
There was a problem hiding this comment.
Here can be: public static function __callStatic($method, array $parameters)
|
Refs #21980. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds macroable functionality to the
Eloquent/Builder, with one exception to the normal implementation — it doesn't use theMacroabletrait.This because the class already has it's own locally scoped macro functionality. For example, when you to enable soft deletes on a specific model. Unfortunately this functionality cannot be globally (statically), hence this change.
To use the
macro()method in both local and static situations, I've removed the method from the class and implemented it via__call()and__callStatic().From my testing, I believe this change maintains 100% backward compatibility.