Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.5] Don't bind macro when it is not a Closure #21980

Merged
merged 1 commit into from
Nov 6, 2017
Merged

[5.5] Don't bind macro when it is not a Closure #21980

merged 1 commit into from
Nov 6, 2017

Conversation

alepeino
Copy link
Contributor

@alepeino alepeino commented Nov 6, 2017

This allows registering any callable as global macro. Probably not many sensible use cases for doing so (in fact, any attempt would have resulted in an error), but this mirrors the behaviour in Macroable as originally intended.

@taylorotwell taylorotwell merged commit a570041 into laravel:5.5 Nov 6, 2017
@vlakoff
Copy link
Contributor

vlakoff commented Nov 9, 2017

Refs #17719.

@vlakoff vlakoff mentioned this pull request Nov 9, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alepeino @vlakoff @taylorotwell