Make error handling a bit more friendly #35381
Conversation
Main idea behind this is to trust folks to properly configure their environment on production. Behaviour is kept, though, on other environments to help users catching potential problems earlier.
lcobucci
force-pushed
the
make-error-handling-a-bit-more-friendly
branch
from
bbbd6ad to
33b3fae
Compare
This ensures that deprecation messages aren't treated as hard errors (a.k.a. a broken app) on Laravel apps. These messages are still logged so that people are aware that they can improve things.
lcobucci
force-pushed
the
make-error-handling-a-bit-more-friendly
branch
from
33b3fae to
806a018
Compare
| if (! $app->environment('production')) { | ||
| error_reporting(-1); | ||
| } |
There was a problem hiding this comment.
I honestly thought about removing this line but it exists since forever - for a reason which I couldn't find in the history.
|
I don't think we can make this kind of change to 8.x, since it's breaking. Maybe this could be considered for master, though. |
|
How are you firing your deprecation errors? They should be silenced like how Symfony does it. Laravel 6 definitely calls deprecated symfony code which fires silenced deprecation errors, but we don't get complaints from people there? |
|
Yep, you need to add an |
|
@GrahamCampbell I disagree with this being a breaking change but your package your rules. I've explained the technical details on why It would be great to have the technical details of why error handling is so aggressive in Laravel (just so your users are aware of the fact that even deprecation in the language crashes their app). Have a great day 👋 |
|
I've been talking to @lcobucci about this and I'm going to investigate all this soon when I find the time for it. I agree we can't make this change on a patch release and at the moment I think I also lean towards removing that line completely. But I need some more time to investigate the actual consequences of doing that and check with the community on how it effects the ecosystem around the framework. |
|
I've sent a PR to fix your package: lcobucci/jwt#568. |
Hello 👋
After releasing a new version of one of my libs I received several messages from Laravel users saying that their apps were broken due to deprecation messages:
This is then an attempt to help other library authors/maintainers not to break end user's apps.