Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silenced deprecation errors #568

Closed
wants to merge 1 commit into from
Closed

Silenced deprecation errors #568

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link

This will fix all the issues people have been posting recently. Firing silenced deprecation errors is the convention. See, for example, Symfony. :)

@lcobucci
Copy link
Owner

lcobucci commented Nov 27, 2020

I already explained before, that's not the approach I want to take for this package.

Deprecations aren't errors and shouldn't be treated like errors, regardless if they come from the language or from a lib.

Thanks for your time on sending this PR, though.

@GrahamCampbell
Copy link
Author

I am confused as to your approach here. Aren't you treating them like errors?

@lcobucci
Copy link
Owner

@GrahamCampbell I'm treating them just like the language does. Please read carefully the explanation I gave on the issue (and on click the links).

@GrahamCampbell
Copy link
Author

Hmm, I still don't think I agree that is the best approach, from a practical perspective.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants