[8.x] Adds a few PHP 8.1 related changes #38404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
force-pushed
the
php81-fixes
branch
4 times, most recently
from
38201f0 to
d468304
Compare
5 tasks
GrahamCampbell
requested changes
Sep 2, 2021
driesvints
force-pushed
the
php81-fixes
branch
from
1269ec9 to
67928ec
Compare
kylekatarnls
approved these changes
Sep 5, 2021
|
@kylekatarnls why have you approved a PR in a broken state? |
|
I would like to see |
|
It’s not ready yet. It’ll probably be another few weeks, at the earliest. Even if the framework code is ready, it’s dependencies are not all ready, which means it still won’t work in practice. |
|
I know, I just released a new fix today for Carbon compatibility with PHP 8.1 interfaces that added new return types. |
I can install Laravel v9 just fine right now. Is there anything custom you're doing maybe that's preventing you to do that? |
driesvints
force-pushed
the
php81-fixes
branch
from
6307d34 to
1c0aa6e
Compare
This was referenced Sep 7, 2021
I think this is covered now. :) |
driesvints
force-pushed
the
php81-fixes
branch
from
8f4dce1 to
0802298
Compare
driesvints
force-pushed
the
php81-fixes
branch
from
0802298 to
133f434
Compare
This reverts commit d5b01d2.
* Makes serializable closures work with PHP 8.1 * Apply fixes from StyleCI * Fixes PHP 7.3 tests * Refactors * Updates deprecated warning Co-authored-by: Dries Vints <dries@vints.io> * Fixes restoring properties * Update QueueServiceProvider.php Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com> Co-authored-by: Dries Vints <dries@vints.io> Co-authored-by: Taylor Otwell <taylor@laravel.com>
2 tasks
…ors and add some missing `#[\ReturnTypeWillChange]` (#38819) * Add explicit `@return` to `{@inheritdoc}` PHPDoc * Use `return null;` when the return type is `null`
GrahamCampbell
approved these changes
Sep 15, 2021
|
@taylorotwell I've skipped the tests that are currently failing in PHP 8.1, so we can make this pull request in a mergeble state. |
nunomaduro
changed the title
victorvilella
pushed a commit
to cdsistemas/framework
that referenced
this pull request
Oct 12, 2021
* Add ReturnTypeWillChange to SessionHandlerInterface usages * Bump commonmark * Fix getIterator * Use Symfony 5.4 components * Dev mockery * Mimic PHP 8.0 * Try removing symfony components * Mockery * Fix type errors in db tests (laravel#38696) * Fix type errors in db tests * Apply fixes from StyleCI Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com> * Additional DB test fixes (laravel#38699) * More DB fixes (laravel#38700) * PHP 8.1 prefer-lowest builds * Remove skipping PHP 8.1 builds * Bump PHPUnit * Revert "PHP 8.1 prefer-lowest builds" This reverts commit d5b01d2. * [8.x] Adds PHP 8.1 support to serializable closures (laravel#38801) * Makes serializable closures work with PHP 8.1 * Apply fixes from StyleCI * Fixes PHP 7.3 tests * Refactors * Updates deprecated warning Co-authored-by: Dries Vints <dries@vints.io> * Fixes restoring properties * Update QueueServiceProvider.php Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com> Co-authored-by: Dries Vints <dries@vints.io> Co-authored-by: Taylor Otwell <taylor@laravel.com> * Fix default value * Fix mb_strlen value * Adds `continue-on-error` for PHP 8.1 * [8.x] Add explicit `@return` annotations in `{@inheritdoc}` from vendors and add some missing `#[\ReturnTypeWillChange]` (laravel#38819) * Add explicit `@return` to `{@inheritdoc}` PHPDoc * Use `return null;` when the return type is `null` * Skips PHP 8.1 failing tests * Skips some more PHP 8.1 related tests * Skips some more PHP 8.1 related tests * Skips some more PHP 8.1 related tests * Skips some more PHP 8.1 related tests * Skips some more PHP 8.1 related tests * Skips some more PHP 8.1 related tests * Skips some more PHP 8.1 related tests * Update SerializableClosure.php Co-authored-by: Graham Campbell <GrahamCampbell@users.noreply.github.com> Co-authored-by: Taylor Otwell <taylorotwell@users.noreply.github.com> Co-authored-by: Nuno Maduro <enunomaduro@gmail.com> Co-authored-by: Taylor Otwell <taylor@laravel.com> Co-authored-by: Wouter J <wouterj@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some additional fixes for PHP 8.1 support. Thanks to @GrahamCampbell for his help with this and third party library support.
Todo
PDO::ATTR_STRINGIFY_FETCHESbehavior: Fix PHP 8.1 build failures #36813 (comment)predis/predisPHP 8.1 compatibilityramsey/uuid: Add support for PHP 8.1 ramsey/uuid#388aws/aws-php-sdkserializable methods: Implements__serialize()and__unserialize()PHP 8.1 magic methods onAws\Credentials\Credentialsclass aws/aws-sdk-php#2316aws/aws-php-sdkDateTimeResult::fromTimestampissue: https://github.com/laravel/framework/runs/3599702797#step:8:166