Add support for PHP 8.1 #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #388 +/- ##
============================================
- Coverage 96.91% 96.13% -0.79%
- Complexity 533 555 +22
============================================
Files 64 64
Lines 1522 1551 +29
============================================
+ Hits 1475 1491 +16
- Misses 47 60 +13
|
|
Hmm, tried to get it to upload coverage from two different runs, hoping it would merge them. Seems not. We need PHP less than 7.4 and PHP at least 7.4 to get 100% coverage on these changes, together. |
9 tasks
|
Friendly ping, @ramsey. cc @nunomaduro |
|
I'll try to take a look this week. 🙂 |
ramsey
approved these changes
Sep 23, 2021
|
Thank you for contributing! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gets this library working on PHP 8.1. The new PHP 7.4 style serialisation is now mandatory, from PHP 8.1 onwards. I've checked that the two incompatible serialisation formats are in fact compatible. The old style can be deserialized just fine: https://3v4l.org/XfUS3. This means upgrading is easy and no risk. On PHP 7.2 and 7.3, there are no changes. On PHP 7.4+, the old style gets deserialized properly, and going forward, the new style will be used for serialisation.