[9.x] Add whereNotMorphedTo, orWhereNotMorphedTo #42264
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the inverse of
whereMorphedTo
, andorWhereMorphedTo
.I've also added tests for new methods and missing test for
orWhereMorphedTo
.The following code could be extracted to a static method on Relation as it's now duplicated.
I wasn't sure on the terminology from the morph map, are they called "keys", or "morph type values", something else? :D
Then I noticed there was already a
getMorphedModel
static methodAnyway I'm open to suggestion on the naming if this code should be extracted.