[9.x] Allow for nullable morphs in whereNotMorphedTo #42878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use the null safe operator to return null polymorphic relationships
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the null safe operator
<=>instead of=to return results with a null polymorphic relationship as well as those not related with a polymorphic relationship. When this method was first introduced in #42264 (by me) null polymorphic relationships were ignored bywhereNotMorphedToandorWhereNotMorphedTo. This was on oversight on my behalf.Thanks to @yngc0der for pointing this out.
For anyone using
whereNotMorphedTowith nullable polymorphic relationships, you were getting incorrect results, here is the fix.