[10.x] HasCasts returning false instead of true #46992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided as a second parameter
driesvints
changed the title
driesvints
reviewed
May 9, 2023
Remove PHP checks (#46993)
milwad-dev
pushed a commit
to milwad-dev/framework
that referenced
this pull request
May 12, 2023
* fix: HasCasts returning false when fully qualified class-name was provided as a second parameter * fix: styling * fix: Removed unecessary PHP check * formatting --------- Co-authored-by: Taylor Otwell <taylor@laravel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current casting implementation, when class is used as a cast type, hasCast is returning false, as it is falling back to else in case class-string is given, which in turn trims it & makes it lowercase. That means f.e. App\Enums\StatusEnum becomes app\enums\statusenum, which in hasCasts function is case-sensitive compared with actual class and is therefore returning false instead of true.
This PR offers a simple fix which checks if provided string is a class instance & if it is, it returns it as is from getCastType function.
Steps to reproduce: