Skip to content

[10.x] HasCasts returning false instead of true #46992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2023
Merged

[10.x] HasCasts returning false instead of true #46992

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6ab0f23
fix: HasCasts returning false when fully qualified class-name was pro…
jure-knezovic May 9, 2023
49242a9
fix: styling
jure-knezovic May 9, 2023
2446290
Merge pull request #1 from laravel/10.x
jure-knezovic May 9, 2023
e5a74d3
fix: Removed unecessary PHP check
jure-knezovic May 9, 2023
2a36fdc
formatting
taylorotwell May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Illuminate/Database/Eloquent/Concerns/HasAttributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,6 +864,8 @@ protected function getCastType($key)
$convertedCastType = 'immutable_custom_datetime';
} elseif ($this->isDecimalCast($castType)) {
$convertedCastType = 'decimal';
} elseif (class_exists($castType)) {
$convertedCastType = $castType;
} else {
$convertedCastType = trim(strtolower($castType));
}
Expand Down
11 changes: 11 additions & 0 deletions tests/Database/DatabaseEloquentModelTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,12 @@ public function testDirtyOnEnumArrayObject()
$this->assertTrue($model->isDirty('asEnumArrayObjectAttribute'));
}

public function testHasCastsOnEnumAttribute()
{
$model = new EloquentModelEnumCastingStub();
$this->assertTrue($model->hasCast('enumAttribute', StringStatus::class));
}

public function testCleanAttributes()
{
$model = new EloquentModelStub(['foo' => '1', 'bar' => 2, 'baz' => 3]);
Expand Down Expand Up @@ -3047,6 +3053,11 @@ protected function serializeDate(DateTimeInterface $date)
}
}

class EloquentModelEnumCastingStub extends Model
{
protected $casts = ['enumAttribute' => StringStatus::class];
}

class EloquentModelDynamicHiddenStub extends Model
{
protected $table = 'stub';
Expand Down