Fix max_execution_time config doesn't work

[sy-records]

Fix #470

Re-create the new Swoole response object to use it to send the response.

[taylorotwell]

What is fd? Can you explain more what this PR is actually doing?

[sy-records]

The client connection $fd number

you can see https://openswoole.com/docs/modules/swoole-http-response-create

[taylorotwell]

This is available on all versions of Swoole? Both Swoole and OpenSwoole?

[sy-records]

swoole is supported since v4.6.0+, openswoole is forked from v4.7.0, so both are supported.

But openswoole has a max_request_execution_time configuration, so I didn't add it for it.

[smortexa]

@sy-records I think OpenSwoole should be added because max_request_execution_time config doesn't work on Octane yet (openswoole/ext-openswoole#136).

[sy-records]

Got it, thanks for the feedback! @smortexa

[taylorotwell]

Sorry - still trying to understand this. How does this fix the problem with a worker hanging? Isn't this response being created on the master process?

[sy-records]

Since the worker process is forced to kill, it is understood to have been detached at this point.
But to keep the response, we use Response::create to recreate the response

[spire-mike]

@sy-records @driesvints it appears that this timeout doesn't work nicely with atomic locks. For example, with config.octane.max_execution_time = 30, and hitting the following route:

Route::get('/test-route', function () {
  Cache::lock('test-lock')->get(function () {
    sleep(60);
  });

  return response('');
});

The test-lock gets set, but it never gets released when the 408 response is sent. Is there some way to 'cleanup' after the request times out?

I'm on Laravel 8.83.11, Octane 1.2.8 using swoole.