[1.x] Ignore Response::create failed
#590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @sy-records |
|
@sy-records OpenSwoole shouldn't be ignored because |
|
cc @doubaokun |
nunomaduro
changed the title
Ignore Response::create failed
nunomaduro
changed the title
Ignore Response::create failedResponse::create failed
|
@sy-records Please set it "Ready for review" once this pull request is fully ready. |
|
@sy-records Can you tell me how exactly reproduce this issue locally? |
nunomaduro
approved these changes
Oct 3, 2022
|
@taylorotwell This looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #588
This feature should only be available for Swoole.
OpenSwoole recommends using the max_request_execution_time configuration.
If a new response cannot be created, we can ignore it.
This will fall back to a page hold instead of an exception.