Fix not highlighting selected items after scrolling on multisearch #130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the bug below.
Laravel\Prompts\multisearch
cannot highlight the items after scrolling.Because
array_is_list()
in line 118 ofLaravel\Prompts\Themes\Default\MultiSearchPromptRenderer
returnsfalse
after scrolling, and$selected
results infalse
.For example, with the list of search result(and
scroll: 5
option):$prompt->visible()
returns an array as follows before scrolling:On the other hand,
$prompt->visible()
returns an array as follows after scrolling:With this array,
array_is_list()
returnsfalse
.I'm not sure if this is the right way,
but I created
isConsecutive()
method inLaravel\Prompts\Themes\Default\Concerns\Number
trait instead ofarray_is_list()
.