Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the issue raised in #130, I found some additional related issues with how the matches are determined after the user has selected something and then cleared the search field.
There were two main issues:
+
operator is preferable, but it's not safe to use with lists.array_is_list
will return true on an empty array, so it's not safe to determine whether the selected values came from a list when the current$matches
is empty. My solution is to capture whether$matches
is a list the first time it is populated and use that for all future decisions.This PR fixes these issues and also fixes the issue raised in #130 in a way that addresses the concerns I raised at #130 (comment).
Thanks to @macocci7 for finding the original issue and helping to solve it!