Fix config/app.php linendings #558
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you checkout a new laravel project in windows your `config/app.php` might end up with linux lineendings.
If you then run `php artisan telescope:install` this string can't be found in the config `{$namespace}\\Providers\EventServiceProvider::class,".PHP_EOL`. And so the `TelescopeServiceProvider` is not added to it.
This bug caused #178, #271, #500 and probably some more like drarkmode not working, when the underlying problem was that the TelescopeServiceProvider wasn't registered.
|
This may be a better candidate for 1.0 branch if it is a bug fix? |
|
Yes, sry i changed the branch. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you checkout a new laravel project on windows your
config/app.phpmight end up with linux lineendings.If you then run
php artisan telescope:installthis string can't be found in the config:"{$namespace}\\Providers\EventServiceProvider::class,".PHP_EOL. And so theTelescopeServiceProvideris not added to it.This caused #178, #271, #500 and probably some more issues like "darkmode not working", when the underlying problem was that the TelescopeServiceProvider wasn't registered.