Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config newline #595

Merged
merged 2 commits into from
Mar 21, 2019
Merged

Fix config newline #595

merged 2 commits into from
Mar 21, 2019

Conversation

scottcharlesworth
Copy link
Contributor

Fixes a bug introduced after #558.

When registering the Telescope service provider the install command attempts to find and replace code with a needle that contains the platform's native end of line symbol, rather than what's currently being used in the file. This can result in the needle not being found on operating systems like Windows, if using Unix LF (like for PSR-2).

Fixes #271, Fixes #470, Fixes #500, Fixes #555

@taylorotwell taylorotwell merged commit 2dbee3d into laravel:2.0 Mar 21, 2019
@rolandstarke
Copy link

rolandstarke commented Mar 28, 2019

#558 was an attempt to solve the same issue, but it was never merged as far as i know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants