Skip to content

Article search broken #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
driesvints opened this issue Dec 21, 2021 · 3 comments · Fixed by #796
Closed

Article search broken #787

driesvints opened this issue Dec 21, 2021 · 3 comments · Fixed by #796

Comments

@driesvints
Copy link
Member

It seems for some reason, articles aren't showing up any more in the search.

Screenshot 2021-12-21 at 16 47 10

Screenshot 2021-12-21 at 16 47 17
@driesvints driesvints added the bug label Dec 21, 2021
@driesvints
Copy link
Member Author

We did merge #785 which fixed search itself so maybe there's one more fix needed?

@driesvints driesvints mentioned this issue Dec 21, 2021
Merged
@aleksrutins
Copy link
Contributor

Hmm, it worked for a moment on my computer:
Screen Shot 2021-12-21 at 10 50 06 AM
But now it doesn't.

@aleksrutins
Copy link
Contributor

Hmm, the responsive search toggle doesn't seem to work either. It seems to be using as a toggle a variable called search, which I don't see in any data bindings — would that conflict with the search function? Maybe that's the actual issue that was happening with #784.

@joedixon joedixon mentioned this issue Dec 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor search to use object laravelio/laravel.io
2 participants
@driesvints @aleksrutins