Refactor search to use object #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #787
To fix the search , I refactored the Alpine component to use an object to handle state which brings it more in line with other components such as the editor.
Doing this allowed me to fix a couple of bugs introduced since the upgrade to Alpine v3 and will make it easier to maintain moving forward.
Some queries have hundreds or thousands of matching results, but we only ever ask for the 5 most relevant so our dropdown menu doesn't get too large. As part of this PR, I am outputting the actual total number of matching results as opposed to just the total we are actually asking for.