-
-
Notifications
You must be signed in to change notification settings - Fork 657
update alpinejs to v3 #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you sure there's no code changes needed? https://alpinejs.dev/upgrade-guide |
Oops! You right .. I'll work on it |
I made changes for alpine v3 and everything work fine, except this weird problem with Article tag filter and pagination (Forum tag filter/pagination works fine)
I really don't know what's the problem here, so if anyone knows why this happens HELP! 2021-11-15.00-14-40.mp4 |
I have pulled this down and am experiencing the same issue. I'll try and take a look later today. Out of interest, I notice you have used |
Yes I had issues without $nextTick. In Alpinejs V3 |
Thanks, I found the same issues. Just to give you a general update. The modal issue you were experiencing seems to be related to Livewire. If I remove We're actually going to remove Livewire from that page and bring it more inline with the forum overview. Once I have done this, I'll rebase this PR and see what (if anything) is still not working as expected. Thank you for your hard work on this. I will need some of the Alpine v3 functionality for the mentions PR I'm working on. |
This exact idea I had when I faced this problem because it appears only with Livewire. |
@faissaloux thank you for your work on this. I'm closing this PR, but your hard work is included on #764 |
resolves #718