Skip to content

update alpinejs to v3 #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

faissaloux
Copy link
Contributor

resolves #718

@driesvints
Copy link
Member

Are you sure there's no code changes needed? https://alpinejs.dev/upgrade-guide

@driesvints driesvints requested a review from joedixon November 14, 2021 17:08
@faissaloux
Copy link
Contributor Author

Are you sure there's no code changes needed? https://alpinejs.dev/upgrade-guide

Oops! You right .. I'll work on it

@faissaloux faissaloux marked this pull request as draft November 14, 2021 17:42
@faissaloux
Copy link
Contributor Author

I made changes for alpine v3 and everything work fine, except this weird problem with Article tag filter and pagination (Forum tag filter/pagination works fine)

  • After selecting a tag the filter applies but the modal open again and won't close.
  • After clicking on a page in pagination bar weirdly opens the filter modal.

I really don't know what's the problem here, so if anyone knows why this happens HELP!

2021-11-15.00-14-40.mp4

@joedixon
Copy link
Contributor

I have pulled this down and am experiencing the same issue. I'll try and take a look later today.

Out of interest, I notice you have used $nextTick in a lot of places. Were you noticing issues without it?

@faissaloux
Copy link
Contributor Author

I have pulled this down and am experiencing the same issue. I'll try and take a look later today.

Out of interest, I notice you have used $nextTick in a lot of places. Were you noticing issues without it?

Yes I had issues without $nextTick. In Alpinejs V3 x-init no longer accepts a callback return so I have to use $nextTick.

https://alpinejs.dev/upgrade-guide#x-init-no-callback

@joedixon
Copy link
Contributor

Yes I had issues without $nextTick. In Alpinejs V3 x-init no longer accepts a callback return so I have to use $nextTick.

https://alpinejs.dev/upgrade-guide#x-init-no-callback

Thanks, I found the same issues.

Just to give you a general update. The modal issue you were experiencing seems to be related to Livewire. If I remove wire:click then it works as expected.

We're actually going to remove Livewire from that page and bring it more inline with the forum overview. Once I have done this, I'll rebase this PR and see what (if anything) is still not working as expected.

Thank you for your hard work on this. I will need some of the Alpine v3 functionality for the mentions PR I'm working on.

@faissaloux
Copy link
Contributor Author

"We're actually going to remove Livewire from that page and bring it more inline with the forum overview"

This exact idea I had when I faced this problem because it appears only with Livewire.

@joedixon
Copy link
Contributor

@faissaloux thank you for your work on this. I'm closing this PR, but your hard work is included on #764

@joedixon joedixon closed this Nov 22, 2021
@faissaloux faissaloux deleted the update-alpinejs branch November 22, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Update Alpine to v3
3 participants