Upgrade Alpine to v3 #764
Merged
Upgrade Alpine to v3 #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joedixon
force-pushed
the
upgrade-alpine
branch
4 times, most recently
from
545c468 to
64d0b4f
Compare
Closed
|
@joedixon this one will need to be rebased now the other PR is merged. |
joedixon
force-pushed
the
upgrade-alpine
branch
from
e8760b8 to
6a10237
Compare
driesvints
requested changes
Nov 25, 2021
There was a problem hiding this comment.
@joedixon seems like some things have gone amis and the commits from the livewire overview refactor are still in here. I think it's best that you rebase and cherry-pick the commits from the Alpine update.
joedixon
force-pushed
the
upgrade-alpine
branch
from
3b53d87 to
3647453
Compare
driesvints
approved these changes
Nov 26, 2021
|
Thanks @joedixon @faissaloux! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm branching from #763 as this includes a rebase. Should any updates be required to the initial PR, I'll rebase again.
This resolves #718 and includes @faissaloux's original PR #740. I submitted as a separate PR as it includes a rebase and I wanted to keep things cleaner.
As part of this PR, I also cleaned up the modal functionality of the site and that now leverages a blade component and Alpine v3's ability to share data between components.