This repository has been archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses add getters to EvaluationReason and hide its subclasses
…lasses completely remove EvaluationReason subclasses
# Conflicts: # src/main/java/com/launchdarkly/sdk/EvaluationReason.java # src/main/java/com/launchdarkly/sdk/LDValue.java
remove @SInCE tags, misc doc fixes, add note about changelogging
make EvaluationDetail non-nullable + use boolean singletons
add JSON helpers, better serialization logic, and Gson adapter
# Conflicts: # src/main/java/com/launchdarkly/sdk/EvaluationDetail.java # src/test/java/com/launchdarkly/sdk/EvaluationReasonTest.java # src/test/java/com/launchdarkly/sdk/LDUserTest.java
improve and rigorously test equals() for all immutable types
more predictable exception behavior for LDValue.parse()
flatten nested multi-kind contexts when building a multi-kind context
…ation fix user JSON validation to require that "custom" is an object or null
disable Windows Java 11 build
…ay-index attribute ref components are always properties, not array indices
remove secondary meta-attribute
remove LDUser as a concrete type
* re-add LDUser type, add conversion to LDContext * misc fixes * re-add test
…-null-key allow anonymous user with null key to be converted to a context
doc comment improvements for user/context types
* update Gradle to 7.3.3 + fix snapshot releases * actually it's 7.6 * update checkstyle version
**Requirements** - [x] I have added test coverage for new or changed functionality - [x] I have followed the repository's [pull request submission guidelines](../blob/main/CONTRIBUTING.md#submitting-pull-requests) - [x] I have validated my changes against all supported platform versions. **Related issues** https://app.shortcut.com/launchdarkly/story/198176/fix-java-contextmultibuilder-to-handle-adding-invalid-contexts **Describe the solution you've provided** Improved null safety of equality checks.
louis-launchdarkly
approved these changes
May 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[2.0.1] - 2023-05-17
Changed:
Fixed: