This repository was archived by the owner on May 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sses add getters to EvaluationReason and hide its subclasses
…lasses completely remove EvaluationReason subclasses
# Conflicts: # src/main/java/com/launchdarkly/sdk/EvaluationReason.java # src/main/java/com/launchdarkly/sdk/LDValue.java
remove @SInCE tags, misc doc fixes, add note about changelogging
make EvaluationDetail non-nullable + use boolean singletons
add JSON helpers, better serialization logic, and Gson adapter
# Conflicts: # src/main/java/com/launchdarkly/sdk/EvaluationDetail.java # src/test/java/com/launchdarkly/sdk/EvaluationReasonTest.java # src/test/java/com/launchdarkly/sdk/LDUserTest.java
improve and rigorously test equals() for all immutable types
more predictable exception behavior for LDValue.parse()
# Conflicts: # CHANGELOG.md # gradle.properties
ensure real nulls can't be stored in an LDValue
# Conflicts: # CHANGELOG.md
And update Android system image for testing to 21 (5.0 Lollipop).
add LDValue.arrayOf() + misc javadoc fixes
add validation of javadoc build in CI
partially revert ch103941 fix that doesn't work in the Java SDK
…evert unrevert some JSON improvements from previous revert
improve Gson integration using reader/writer delegation - take 2
…e previous merge)
bwoskow-ld
approved these changes
Apr 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[1.1.0] - 2021-04-22
This release makes improvements to the helper methods for using Gson and Jackson for JSON conversion.
Added:
LDGson.valueToJsonElement
andLDGson.valueMapToJsonElementMap
: convenience methods for applications that use Gson types.LDValue.arrayOf()
Changed:
com.launchdarkly.sdk.json
, the implementations ofLDGson.typeAdapters
andLDJackson.module
have been changed for better efficiency in deserialization. Instead of creating an intermediate string representation and re-parsing that, they now have a more direct way for the internal deserialization logic to interact with the streaming parser in the application's Gson or Jackson instance.Fixed:
Gson.toJsonTree
now works with LaunchDarkly types, as long as you have configured it as described incom.launchdarkly.sdk.json.LDGson
. Previously, Gson was able to convert these types to and from JSON string data, buttoJsonTree
did not work due to a known issue with theJsonWriter.jsonValue
method; the SDK code no longer uses that method.LDValue.parse()
now returnsLDValue.ofNull()
instead of an actual null reference if the JSON string isnull
.EvaluationDetail<LDValue>
from JSON, if thevalue
property isnull
, it will now translate this intoLDValue.ofNull()
rather than an actual null reference.