prepare 7.5.0 release #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix broken indirect/patch request, add tests for feature requestor
fix autodoc options to exclude magic methods
(re)implement setting proxy URL by environment variable
add config option for proxy URL
add Python 3.8 CI build, and make syntax warnings fatal
…-types misc fixes to test data docs + add type hints
# Conflicts: # ldclient/integrations/test_data.py
…ate-methods remove some methods from the public test_data API
update CONTRIBUTING.md and provide make targets
…to verify rule evaluation
…n start to avoid delays in TestData initialization
Our contract tests depend on flask v1, which in turn depends on Jinja 2. Both of these are terribly dated and no longer supported. Jinja depends on markupsafe. markupsafe recently updated its code to no longer provide soft_unicode which in turn broke Jinja. Updating to the latest flask keeps all transitive dependencies better aligned and addresses this mismatch.
…-rule-builder-op-bugfix Bugfix for FlagRuleBuilder evaluation internals
The test harness may send explicit None values which should be treated the same as if the value was omitted entirely.
When we return a `('', 204)` response from the flask handler, [Werkzeug
intentionally removes the 'Content-Type' header][1], which causes the
response to be created as a chunked response.
The test harness is likely seeing a 204 response and isn't trying to
read anything more from the stream. But since we are re-using
connections, the next time it reads from the stream, it sees the
`0\r\n\r\n` chunk and outputs an error:
> 2022/04/20 14:23:39 Unsolicited response received on idle HTTP channel starting with "0\r\n\r\n"; err=<nil>
Changing this response to 202 causes Werkzeug to return an empty
response and silences the error.
[1]: https://github.com/pallets/werkzeug/blob/560dd5f320bff318175f209595d42f5a80045417/src/werkzeug/wrappers/response.py#L540
When calculating a bucket, we get the bucketable value from the specified bucket by attribute. If this value is a string or an int, we can use it. Otherwise, we return None. Python considers a bool an instance of an int, which isn't what we want. So we need to add an explicit exclusion for this.
…dardize-relay-proxy-in-daemon-mode-in Adds link to Relay Proxy docs
Originally this was pinned to a max version to deal with the incompatibility of Python 3.3 and the `typing` package. See [this PR][1]. Now that we now only support >=3.5, we can safely relax this restriction again. [1]: launchdarkly/python-server-sdk-private#120
eli-darkly
suggested changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[7.5.0] - 2022-06-15
Changed: