Improved jsdoc/type-checking setup

[elpoelma]

Overview

This PR improves the jsdoc/type-checking setup of this javascript service.
Specifically it sets up:

• A more strict tsconfig.json
• Addition of the typescript dev-dependency
• Addition of some jsdoc types
• Inclusion of @ts-nocheck in files with missing/incorrect types
• A slight refactor of the woodpecker set-up

How to test/reproduce

• Both the typescript compiler and eslint should not fail
• When integrated in this stack, this service should still behave the same functionally

Challenges/uncertainties

I included two logic changes:

• Moved prefixMap from a Map to a readonly Record to get better types
• Fix a bug where the incorrect translation key was being used.
• This set-up will allow us to make this service gradually more type-safe

Checks PR readiness

• UI: works on smaller screen sizes
• UI: feedback for any loading/error states
• Check cancel/go-back flows
• Check database state correct when deleting/updating (especially regarding relationships)
• changelog
• npm lint
• no new deprecations

[lagartoverde]

looks good, added some prefixMap conversions you forgot :)

[piemonkey]

Hmm, given the need to disable TS on so many files to avoid strict mode errors, I think it would make sense for us to try https://github.com/allegro/typescript-strict-plugin , which should allow us to toggle strict mode per file, and so still get limited typechecking in those files.

[elpoelma]

Hmm, given the need to disable TS on so many files to avoid strict mode errors, I think it would make sense for us to try https://github.com/allegro/typescript-strict-plugin , which should allow us to toggle strict mode per file, and so still get limited typechecking in those files.

This indeed sounds like a good idea. I'll check it out and see what impact it has on performance of the language server. There's also a draft PR open to add support for this in typescript: microsoft/TypeScript#49886

[elpoelma]

@piemonkey I added the plugin and was able to replace most @ts-nocheck statements by @ts-strict-ignore. There are still some places (e.g. the test files) where the @ts-nocheck was also necessary.

[piemonkey]

Looks great :)