Allow some per file compiler options #49886

weswigham · 2022-07-12T23:45:35Z

In this PR, we allow certain compiler options to be configured via comments within a file for the scope of that file using a comment of the form // @ts-option [value]. This means you can write, for example:

Currently this supports everything in the "strict type checks" and "additional checks" segments of options, which includes:

strict
noImplicitAny
strictNullChecks
strictFunctionTypes
strictBindCallApply
strictPropertyInitialization
noImplicitThis
useUnknownInCatchVariables
alwaysStrict
noUnusedLocals
noUnusedParameters
exactOptionalPropertyTypes
noImplicitReturns
noFallthroughCasesInSwitch
noUncheckedIndexedAccess
noImplicitOverride
noPropertyAccessFromIndexSignature

Adding more options to this list is just a matter of adding the allowedAsPragma flag to the definition of the option in commandLineParser.ts and using getFileLocalCompilerOption to look up the option at relevant locations, so we can easily add support for more local options as needed (by far the hardest was strictNullChecks).

Fixes #31035

I've wanted to look into this since I originally added the generic pragma-parsing infrastructure for @ts-check and related comments.

To start off the discussion, in the linked issue, @RyanCavanaugh asked:

It's not really even clear what this means - if you have a type declared in file A, another type in file B, and you try to relate them in file C, whose value of strictFunctionTypes is in play?

Currently in this PR, whichever is stricter. If either file the types originated from has it set, it's related strictly. Could go the other way and relate loosely if either is explicitly non-strict if looser checking is more preferable. Honestly, most of these "which context controls the flag" already have fairly canonical answers, either because we already look up a context to check JS-y-ness (for JS-file-specific-behaviors or error ignoring), or to issue an error in (in which case the error node location is a pretty logical context).

Anyways, I'm hoping this implementation can jumpstart discussion on the value of in-file pragmas for compiler options, specifically with the goal of bikeshedding the syntax and what options we should ultimately expose on a per-file basis. (Technically, I've tried to make the internal APIs for adding new per-file pragmas very type-safe and very easy to use.)

I strongly recommend reviewing this by-commit if possible. Specifically, the changes to strictNullChecks to support this are extensive and are contained in f5134a5.

weswigham · 2022-07-12T23:45:48Z

@typescript-bot pack this

typescript-bot · 2022-07-12T23:45:51Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at 459196b. You can monitor the build here.

weswigham · 2022-07-13T00:18:00Z

@typescript-bot pack this now that baselines should be green again :)

typescript-bot · 2022-07-13T00:18:03Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at 97bba40. You can monitor the build here.

MartinJohns · 2022-07-13T06:54:38Z

Is this opt-in only, or will it be possible to opt-out as well?

weswigham · 2022-07-13T07:40:07Z

You should be able to write things like // @ts-strict false and the like. Parameters get parsed the same way they do on the command line.

weswigham · 2022-07-13T19:56:56Z

@typescript-bot pack this

typescript-bot · 2022-07-13T19:57:12Z

Heya @weswigham, I've started to run the tarball bundle task on this PR at ef3813c. You can monitor the build here.

typescript-bot · 2022-07-13T20:23:51Z

Hey @weswigham, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/129711/artifacts?artifactName=tgz&fileId=07F2813C225AA6CC371299076DC3BF08FFE79A5C45BC00165AB9D270F70FC3FB02&fileName=/typescript-4.8.0-insiders.20220713.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.8.0-pr-49886-8".;

WIP 2 Less WIP - Only exactOptionalPropertyTypes and strictNullChecks left Pragmas are case-insensitive Fix harness types Fixup baselines File-local support for exactOptionalPropertyTypes Fix lints Cache getSourceFileOfNode within the checker

...nes/reference/genericConditionalConstrainedToUnknownNotAssignableToConcreteObject.errors.txt

weswigham · 2022-08-31T18:17:46Z

This should be cleaned up and ready to go, so let's get the bot to do some tests on this iteration (not the much has changed implementation-wise since I ran them on the strict null checks-dedicated draft pr).

@typescript-bot pack this
@typescript-bot user test this inline
@typescript-bot test this
@typescript-bot run dt
@typescript-bot perf test this

typescript-bot · 2022-08-31T18:17:49Z

Heya @weswigham, I've started to run the extended test suite on this PR at 4bde2e7. You can monitor the build here.

typescript-bot · 2022-08-31T18:17:49Z

Heya @weswigham, I've started to run the perf test suite on this PR at 4bde2e7. You can monitor the build here.

Update: The results are in!

…ion" This reverts commit b632e6a.

weswigham · 2022-09-21T19:47:56Z

@typescript-bot perf test this faster

typescript-bot · 2022-09-21T19:48:00Z

Heya @weswigham, I've started to run the abridged perf test suite on this PR at 638a3bf. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-21T20:06:58Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49886

_Metric	_main	₄₉₈₈₆	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{339,137k (± 0.01%)}	_{343,109k (± 0.01%)}	_{+3,972k (+ 1.17%)}	_343,079k	_343,167k
_{Parse Time}	_{2.07s (± 0.56%)}	_{2.06s (± 0.57%)}	_{-0.01s (- 0.39%)}	_2.04s	_2.09s
_{Bind Time}	_{0.80s (± 0.70%)}	_{0.80s (± 0.62%)}	_{-0.00s (- 0.25%)}	_0.79s	_0.81s
_{Check Time}	_{5.86s (± 0.41%)}	_{6.36s (± 0.40%)}	_{+0.50s (+ 8.55%)}	_6.29s	_6.43s
_{Emit Time}	_{6.25s (± 0.48%)}	_{6.27s (± 0.74%)}	_{+0.02s (+ 0.38%)}	_6.18s	_6.35s
_{Total Time}	_{14.97s (± 0.28%)}	_{15.49s (± 0.40%)}	_{+0.51s (+ 3.43%)}	_15.30s	_15.58s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,085k (± 0.14%)}	_{194,044k (± 0.01%)}	_{+3,960k (+ 2.08%)}	_193,973k	_194,101k
_{Parse Time}	_{0.86s (± 0.98%)}	_{0.86s (± 0.68%)}	_{-0.00s (- 0.23%)}	_0.85s	_0.87s
_{Bind Time}	_{0.48s (± 1.03%)}	_{0.49s (± 1.01%)}	_{+0.00s (+ 0.21%)}	_0.48s	_0.50s
_{Check Time}	_{6.73s (± 0.34%)}	_{7.29s (± 0.41%)}	_{+0.56s (+ 8.26%)}	_7.23s	_7.36s
_{Emit Time}	_{2.40s (± 0.63%)}	_{2.41s (± 0.85%)}	_{+0.01s (+ 0.46%)}	_2.37s	_2.46s
_{Total Time}	_{10.48s (± 0.25%)}	_{11.05s (± 0.34%)}	_{+0.57s (+ 5.44%)}	_10.99s	_11.14s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,573k (± 0.01%)}	_{333,793k (± 0.01%)}	_{+7,220k (+ 2.21%)}	_333,741k	_333,831k
_{Parse Time}	_{1.59s (± 0.79%)}	_{1.58s (± 0.60%)}	_{-0.01s (- 0.57%)}	_1.56s	_1.60s
_{Bind Time}	_{0.73s (± 0.50%)}	_{0.72s (± 0.55%)}	_{-0.01s (- 0.69%)}	_0.71s	_0.73s
_{Check Time}	_{5.71s (± 0.29%)}	_{6.37s (± 0.46%)}	_{+0.66s (+11.49%)}	_6.29s	_6.43s
_{Emit Time}	_{3.35s (± 0.30%)}	_{3.36s (± 0.92%)}	_{+0.01s (+ 0.33%)}	_3.32s	_3.47s
_{Total Time}	_{11.38s (± 0.24%)}	_{12.03s (± 0.47%)}	_{+0.65s (+ 5.74%)}	_11.92s	_12.18s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,660k (± 0.01%)}	_{295,357k (± 0.01%)}	_{+5,697k (+ 1.97%)}	_295,292k	_295,395k
_{Parse Time}	_{1.29s (± 0.64%)}	_{1.29s (± 0.82%)}	_{0.00s ( 0.00%)}	_1.28s	_1.32s
_{Bind Time}	_{0.79s (± 0.92%)}	_{0.79s (± 0.78%)}	_{-0.00s (- 0.13%)}	_0.78s	_0.81s
_{Check Time}	_{5.37s (± 0.58%)}	_{5.90s (± 0.45%)}	_{+0.53s (+ 9.79%)}	_5.85s	_5.97s
_{Emit Time}	_{3.60s (± 0.77%)}	_{3.60s (± 0.72%)}	_{+0.00s (+ 0.08%)}	_3.53s	_3.64s
_{Total Time}	_{11.06s (± 0.52%)}	_{11.59s (± 0.44%)}	_{+0.53s (+ 4.83%)}	_11.47s	_11.71s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,848k (± 0.00%)}	_{439,061k (± 0.00%)}	_{+2,213k (+ 0.51%)}	_439,018k	_439,106k
_{Parse Time}	_{1.88s (± 0.51%)}	_{1.87s (± 0.47%)}	_{-0.01s (- 0.27%)}	_1.85s	_1.89s
_{Bind Time}	_{0.58s (± 0.96%)}	_{0.58s (± 0.99%)}	_{+0.00s (+ 0.35%)}	_0.57s	_0.59s
_{Check Time}	_{12.94s (± 0.71%)}	_{14.20s (± 0.62%)}	_{+1.25s (+ 9.68%)}	_13.99s	_14.35s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.40s (± 0.61%)}	_{16.65s (± 0.54%)}	_{+1.25s (+ 8.11%)}	_16.45s	_16.80s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{547,672k (± 0.01%)}	_{549,075k (± 0.00%)}	_{+1,402k (+ 0.26%)}	_549,026k	_549,112k
_{Parse Time}	_{2.62s (± 0.48%)}	_{2.62s (± 0.60%)}	_{+0.00s (+ 0.11%)}	_2.60s	_2.67s
_{Bind Time}	_{0.98s (± 1.55%)}	_{0.98s (± 1.23%)}	_{-0.01s (- 0.71%)}	_0.96s	_1.00s
_{Check Time}	_{1.51s (± 0.64%)}	_{1.60s (± 0.46%)}	_{+0.09s (+ 5.89%)}	_1.58s	_1.62s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 3.14%)}	_{+0.00s (+ 1.43%)}	_0.07s	_0.08s
_{Total Time}	_{5.19s (± 0.41%)}	_{5.27s (± 0.45%)}	_{+0.08s (+ 1.58%)}	_5.23s	_5.33s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₉₈₈₆	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

weswigham · 2022-09-21T21:02:36Z

@typescript-bot perf test this faster

typescript-bot · 2022-09-21T21:02:39Z

Heya @weswigham, I've started to run the abridged perf test suite on this PR at 5b77328. You can monitor the build here.

Update: The results are in!

typescript-bot · 2022-09-21T21:21:38Z

@weswigham
The results of the perf run you requested are in!

Here they are:

Comparison Report - main..49886

_Metric	_main	₄₉₈₈₆	_Delta	_Best	_Worst
_{Angular - node (v14.15.1, x64)}
_{Memory used}	_{339,137k (± 0.01%)}	_{343,063k (± 0.01%)}	_{+3,926k (+ 1.16%)}	_343,018k	_343,104k
_{Parse Time}	_{2.07s (± 0.56%)}	_{2.08s (± 1.17%)}	_{+0.02s (+ 0.73%)}	_2.05s	_2.17s
_{Bind Time}	_{0.80s (± 0.70%)}	_{0.80s (± 0.59%)}	_{+0.00s (+ 0.25%)}	_0.79s	_0.81s
_{Check Time}	_{5.86s (± 0.41%)}	_{6.38s (± 0.34%)}	_{+0.53s (+ 8.98%)}	_6.34s	_6.43s
_{Emit Time}	_{6.25s (± 0.48%)}	_{6.30s (± 0.74%)}	_{+0.05s (+ 0.80%)}	_6.21s	_6.43s
_{Total Time}	_{14.97s (± 0.28%)}	_{15.56s (± 0.49%)}	_{+0.59s (+ 3.94%)}	_15.45s	_15.76s
_{Compiler-Unions - node (v14.15.1, x64)}
_{Memory used}	_{190,085k (± 0.14%)}	_{193,913k (± 0.13%)}	_{+3,828k (+ 2.01%)}	_192,934k	_194,067k
_{Parse Time}	_{0.86s (± 0.98%)}	_{0.86s (± 0.65%)}	_{-0.00s (- 0.12%)}	_0.85s	_0.87s
_{Bind Time}	_{0.48s (± 1.03%)}	_{0.49s (± 0.61%)}	_{+0.00s (+ 0.62%)}	_0.48s	_0.49s
_{Check Time}	_{6.73s (± 0.34%)}	_{7.32s (± 0.45%)}	_{+0.59s (+ 8.70%)}	_7.21s	_7.39s
_{Emit Time}	_{2.40s (± 0.63%)}	_{2.41s (± 0.88%)}	_{+0.01s (+ 0.33%)}	_2.37s	_2.48s
_{Total Time}	_{10.48s (± 0.25%)}	_{11.07s (± 0.40%)}	_{+0.60s (+ 5.69%)}	_10.95s	_11.17s
_{Monaco - node (v14.15.1, x64)}
_{Memory used}	_{326,573k (± 0.01%)}	_{333,806k (± 0.01%)}	_{+7,233k (+ 2.21%)}	_333,761k	_333,858k
_{Parse Time}	_{1.59s (± 0.79%)}	_{1.59s (± 0.84%)}	_{+0.01s (+ 0.57%)}	_1.56s	_1.63s
_{Bind Time}	_{0.73s (± 0.50%)}	_{0.73s (± 0.82%)}	_{0.00s ( 0.00%)}	_0.71s	_0.74s
_{Check Time}	_{5.71s (± 0.29%)}	_{6.37s (± 0.42%)}	_{+0.66s (+11.56%)}	_6.31s	_6.43s
_{Emit Time}	_{3.35s (± 0.30%)}	_{3.38s (± 1.04%)}	_{+0.03s (+ 0.84%)}	_3.33s	_3.50s
_{Total Time}	_{11.38s (± 0.24%)}	_{12.07s (± 0.44%)}	_{+0.70s (+ 6.12%)}	_11.97s	_12.24s
_{TFS - node (v14.15.1, x64)}
_{Memory used}	_{289,660k (± 0.01%)}	_{295,349k (± 0.01%)}	_{+5,689k (+ 1.96%)}	_295,298k	_295,389k
_{Parse Time}	_{1.29s (± 0.64%)}	_{1.30s (± 0.43%)}	_{+0.00s (+ 0.31%)}	_1.28s	_1.31s
_{Bind Time}	_{0.79s (± 0.92%)}	_{0.79s (± 0.75%)}	_{+0.00s (+ 0.25%)}	_0.78s	_0.81s
_{Check Time}	_{5.37s (± 0.58%)}	_{5.90s (± 0.38%)}	_{+0.53s (+ 9.79%)}	_5.84s	_5.94s
_{Emit Time}	_{3.60s (± 0.77%)}	_{3.60s (± 0.53%)}	_{+0.00s (+ 0.03%)}	_3.57s	_3.65s
_{Total Time}	_{11.06s (± 0.52%)}	_{11.60s (± 0.18%)}	_{+0.54s (+ 4.87%)}	_11.54s	_11.64s
_{material-ui - node (v14.15.1, x64)}
_{Memory used}	_{436,848k (± 0.00%)}	_{439,032k (± 0.01%)}	_{+2,184k (+ 0.50%)}	_438,969k	_439,073k
_{Parse Time}	_{1.88s (± 0.51%)}	_{1.88s (± 0.64%)}	_{+0.01s (+ 0.43%)}	_1.85s	_1.91s
_{Bind Time}	_{0.58s (± 0.96%)}	_{0.58s (± 0.81%)}	_{+0.00s (+ 0.35%)}	_0.57s	_0.59s
_{Check Time}	_{12.94s (± 0.71%)}	_{14.24s (± 0.48%)}	_{+1.29s (+ 9.97%)}	_14.10s	_14.38s
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_{0.00s ( NaN%)}	_0.00s	_0.00s
_{Total Time}	_{15.40s (± 0.61%)}	_{16.70s (± 0.44%)}	_{+1.30s (+ 8.46%)}	_16.54s	_16.86s
_{xstate - node (v14.15.1, x64)}
_{Memory used}	_{547,672k (± 0.01%)}	_{549,070k (± 0.00%)}	_{+1,398k (+ 0.26%)}	_549,029k	_549,114k
_{Parse Time}	_{2.62s (± 0.48%)}	_{2.63s (± 0.63%)}	_{+0.01s (+ 0.50%)}	_2.58s	_2.66s
_{Bind Time}	_{0.98s (± 1.55%)}	_{0.99s (± 1.20%)}	_{+0.00s (+ 0.41%)}	_0.96s	_1.02s
_{Check Time}	_{1.51s (± 0.64%)}	_{1.61s (± 0.68%)}	_{+0.10s (+ 6.55%)}	_1.59s	_1.63s
_{Emit Time}	_{0.07s (± 0.00%)}	_{0.07s (± 0.00%)}	_{0.00s ( 0.00%)}	_0.07s	_0.07s
_{Total Time}	_{5.19s (± 0.41%)}	_{5.30s (± 0.49%)}	_{+0.11s (+ 2.04%)}	_5.22s	_5.35s

System

_{Machine Name}	_ts-ci-ubuntu
_Platform	_{linux 4.4.0-210-generic}
_Architecture	_x64
_{Available Memory}	_{16 GB}
_{Available Memory}	_{15 GB}
_CPUs	_{4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz}

Hosts

node (v14.15.1, x64)

Scenarios

Angular - node (v14.15.1, x64)
Compiler-Unions - node (v14.15.1, x64)
Monaco - node (v14.15.1, x64)
TFS - node (v14.15.1, x64)
material-ui - node (v14.15.1, x64)
xstate - node (v14.15.1, x64)

_Benchmark	_Name	_Iterations
_Current	₄₉₈₈₆	₁₀
_Baseline	_main	₁₀

Developer Information:

Download Benchmark

neolectron

lgtm

abdatta · 2023-01-10T08:10:21Z

Hi, any updates on this? Now that it is approved, can we expect it to be merged anytime soon?

abdatta · 2023-01-11T19:26:41Z

@typescript-bot pack this

abdatta · 2023-01-13T07:35:44Z

Hey @weswigham, if you don't mind, can you please ask the @typescript-bot to pack this latest iteration? It seems to listen to the PR author. I wanted to try it out in some local project. Thanks!

jakebailey · 2023-01-13T07:38:46Z

@typescript-bot pack this

typescript-bot · 2023-01-13T07:38:49Z

Heya @jakebailey, I've started to run the tarball bundle task on this PR at 5b77328. You can monitor the build here.

typescript-bot · 2023-01-13T07:42:05Z

Hey @jakebailey, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/142539/artifacts?artifactName=tgz&fileId=84F197BAEF8A6E106505CC1E9EE470B6D941DF8AA3E6B9D2787B60D6817BEDF002&fileName=/typescript-4.9.0-insiders.20230113.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/pr-build@4.9.0-pr-49886-73".;

abdatta · 2023-01-13T07:59:39Z

Thanks @jakebailey!

xiaoxiangmoe · 2023-01-13T11:46:53Z

There is only a week before ts 5.0 beta. Maybe this feature will be avaliable after 5.1

abdatta · 2023-01-15T08:55:49Z

I'm seeing these kinds of errors despite turning off the check. Is this expected? Ideally it should not be imo as turning off SNC from tsconfig would not generate this error.

Playground Link

eyelidlessness · 2023-01-22T00:38:48Z

I was writing up a much longer background for this, but I’m exhausted on Saturday, and don’t want to lose the context before I bail. I’m happy to come back and fill in details of why I’m asking if it seems really bonkers to ask.

Is there any possibility this could allow specifying:

tsconfig path rather than individual config items
a range of lines it applies to versus a whole module

The use case prompting me to ask involves using Playwright as a library, and would incredibly simplify its usage (and type safety) for a single function proxy as I transition a library from dependence on Node APIs and native dependencies to be usable in browser. It’s definitely not a common use case, but I can imagine others which might benefit from specifying a given callback is being shuttled off to be executed in an entirely different environment.

DanielRosenwasser · 2023-01-23T19:52:44Z

Hey all, the future of this feature is somewhat uncertain. Any time the type system has to make a decision based on strictness, it now has to walk up to the top of the file and check for strictness directives. If not that, every node (or almost every node) of our syntax trees has to get a little bit bigger to hold onto that information.

This has a type-checking performance impact that is higher than we can accept. There might be some optimizations we can make for the more common case of no file-specific options within a project, but that leads to some unpredictable performance cliffs as soon as one is added.

So this won't make its way into TypeScript 5.0, and it's unclear if we'll be able to bring it in in the future either.

debadree25 · 2024-05-30T16:45:15Z

Hey all, the future of this feature is somewhat uncertain. Any time the type system has to make a decision based on strictness, it now has to walk up to the top of the file and check for strictness directives. If not that, every node (or almost every node) of our syntax trees has to get a little bit bigger to hold onto that information.

This has a type-checking performance impact that is higher than we can accept. There might be some optimizations we can make for the more common case of no file-specific options within a project, but that leads to some unpredictable performance cliffs as soon as one is added.

So this won't make its way into TypeScript 5.0, and it's unclear if we'll be able to bring it in in the future either.

Can this option be not added as an opt in? like an option in compilerOptions something like "enableIncrementalStrictCheckComments" or something? this can be an incredibly helpful option I think most people would be happy to accept a performance penalty to allow for incremental migration to safer and better code.

I came across this issue searching for a way to enable incremental strict checks on a 50k+ line codebase on which enabling strict checks throws up 3k+ errors 🙈 while i understand plugins exist for this having this on a compiler level can be so much better!

I know no nothing about typescripts development process/priorities so if anything i said here is wrong/doesnt make sense I apologise but I sincerely hope you consider the request!

Thank you to the author and typescript team for their time and effort on this!

typescript-bot assigned weswigham Jul 12, 2022

typescript-bot added the Author: Team label Jul 12, 2022

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jul 12, 2022

jakebailey mentioned this pull request Jul 17, 2022

Strict type-checking on a per-file basis "@ts-strict" #28306

Open

4 tasks

Dremora mentioned this pull request Jul 26, 2022

A project reference setup using both strict and non-strict modes produces errors in VS Code #50035

Closed

weswigham mentioned this pull request Aug 17, 2022

Per file option: strictNullChecks #50347

Closed

weswigham added 3 commits August 24, 2022 10:55

Parsing for per-file options, WIP

913e68b

WIP 2 Less WIP - Only exactOptionalPropertyTypes and strictNullChecks left Pragmas are case-insensitive Fix harness types Fixup baselines File-local support for exactOptionalPropertyTypes Fix lints Cache getSourceFileOfNode within the checker

Per-file strictNullChecks support

f5134a5

strictNullChecks pragma tests, including cross-file type behavior

b45165d

weswigham force-pushed the per-file-options branch from ef3813c to b45165d Compare August 24, 2022 18:04

DanielRosenwasser mentioned this pull request Aug 25, 2022

TypeScript 4.9 Iteration Plan #50457

Closed

jakebailey reviewed Aug 30, 2022

View reviewed changes

...nes/reference/genericConditionalConstrainedToUnknownNotAssignableToConcreteObject.errors.txt Outdated Show resolved Hide resolved

Tests for all new pragmas

fe5600e

weswigham force-pushed the per-file-options branch from 1be381d to fe5600e Compare August 31, 2022 17:38

weswigham added 2 commits August 31, 2022 11:00

Error on duplicate local compiler options

e25d5a8

Fix lint

5b336c6

weswigham marked this pull request as ready for review August 31, 2022 18:09

Merge branch 'main' into per-file-options

4bde2e7

weswigham added 2 commits September 21, 2022 12:24

Revert "Once again, set snc to fixed value to see perf floor of funct…

08dfb4c

…ion" This reverts commit b632e6a.

Remove now duplicated handling of missingType

638a3bf

Remove now-redundant control flow filtering logic

5b77328

swandir mentioned this pull request Oct 6, 2022

Configurable option for isolated type-checking of modules denoland/deno#13564

Closed

DanielRosenwasser mentioned this pull request Oct 31, 2022

TypeScript 5.0 Iteration Plan #51362

Closed

azu mentioned this pull request Nov 2, 2022

2022-11-02のJS: Node.js 18.12.0 LTS、Babel 7.20.0、TypeScript 4.9 RC jser/jser.github.io#1016

Merged

neolectron approved these changes Nov 4, 2022

View reviewed changes

andrewbranch mentioned this pull request May 10, 2023

Proposal: Encode and read emit-affecting compiler options in declaration files #54212

Open

ssalbdivad mentioned this pull request Jul 17, 2023

Expanded function return type for certain mapped types in compiled output causes index access error #55049

Open

fatcerberus mentioned this pull request Jul 19, 2023

Optional nested readonly type changes type of property adding undefined #55058

Closed

weswigham added the Experiment A fork with an experimental idea which might not make it into master label Aug 13, 2024

weswigham marked this pull request as draft August 13, 2024 22:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow some per file compiler options #49886

Allow some per file compiler options #49886

weswigham commented Jul 12, 2022 •

edited

Loading

weswigham commented Jul 12, 2022

typescript-bot commented Jul 12, 2022 •

edited

Loading

weswigham commented Jul 13, 2022

typescript-bot commented Jul 13, 2022 •

edited

Loading

MartinJohns commented Jul 13, 2022

weswigham commented Jul 13, 2022

weswigham commented Jul 13, 2022

typescript-bot commented Jul 13, 2022 •

edited

Loading

typescript-bot commented Jul 13, 2022 •

edited

Loading

weswigham commented Aug 31, 2022

typescript-bot commented Aug 31, 2022 •

edited

Loading

typescript-bot commented Aug 31, 2022 •

edited

Loading

weswigham commented Sep 21, 2022

typescript-bot commented Sep 21, 2022 •

edited

Loading

typescript-bot commented Sep 21, 2022

weswigham commented Sep 21, 2022

typescript-bot commented Sep 21, 2022 •

edited

Loading

typescript-bot commented Sep 21, 2022

neolectron left a comment

abdatta commented Jan 10, 2023

abdatta commented Jan 11, 2023

abdatta commented Jan 13, 2023

jakebailey commented Jan 13, 2023

typescript-bot commented Jan 13, 2023 •

edited

Loading

typescript-bot commented Jan 13, 2023 •

edited

Loading

abdatta commented Jan 13, 2023

xiaoxiangmoe commented Jan 13, 2023

abdatta commented Jan 15, 2023 •

edited

Loading

eyelidlessness commented Jan 22, 2023

DanielRosenwasser commented Jan 23, 2023

debadree25 commented May 30, 2024

Allow some per file compiler options #49886

Are you sure you want to change the base?

Allow some per file compiler options #49886

Conversation

weswigham commented Jul 12, 2022 • edited Loading

weswigham commented Jul 12, 2022

typescript-bot commented Jul 12, 2022 • edited Loading

weswigham commented Jul 13, 2022

typescript-bot commented Jul 13, 2022 • edited Loading

MartinJohns commented Jul 13, 2022

weswigham commented Jul 13, 2022

weswigham commented Jul 13, 2022

typescript-bot commented Jul 13, 2022 • edited Loading

typescript-bot commented Jul 13, 2022 • edited Loading

weswigham commented Aug 31, 2022

typescript-bot commented Aug 31, 2022 • edited Loading

typescript-bot commented Aug 31, 2022 • edited Loading

weswigham commented Sep 21, 2022

typescript-bot commented Sep 21, 2022 • edited Loading

typescript-bot commented Sep 21, 2022

weswigham commented Sep 21, 2022

typescript-bot commented Sep 21, 2022 • edited Loading

typescript-bot commented Sep 21, 2022

neolectron left a comment

Choose a reason for hiding this comment

abdatta commented Jan 10, 2023

abdatta commented Jan 11, 2023

abdatta commented Jan 13, 2023

jakebailey commented Jan 13, 2023

typescript-bot commented Jan 13, 2023 • edited Loading

typescript-bot commented Jan 13, 2023 • edited Loading

abdatta commented Jan 13, 2023

xiaoxiangmoe commented Jan 13, 2023

abdatta commented Jan 15, 2023 • edited Loading

eyelidlessness commented Jan 22, 2023

DanielRosenwasser commented Jan 23, 2023

debadree25 commented May 30, 2024

weswigham commented Jul 12, 2022 •

edited

Loading

typescript-bot commented Jul 12, 2022 •

edited

Loading

typescript-bot commented Jul 13, 2022 •

edited

Loading

typescript-bot commented Jul 13, 2022 •

edited

Loading

typescript-bot commented Jul 13, 2022 •

edited

Loading

typescript-bot commented Aug 31, 2022 •

edited

Loading

typescript-bot commented Aug 31, 2022 •

edited

Loading

typescript-bot commented Sep 21, 2022 •

edited

Loading

typescript-bot commented Sep 21, 2022 •

edited

Loading

typescript-bot commented Jan 13, 2023 •

edited

Loading

typescript-bot commented Jan 13, 2023 •

edited

Loading

abdatta commented Jan 15, 2023 •

edited

Loading