Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport rolling to humble #223

Closed
wants to merge 27 commits into from
Closed

Conversation

mhubii
Copy link
Member

@mhubii mhubii commented Nov 20, 2024

No description provided.

@mhubii mhubii closed this Nov 20, 2024
@mhubii mhubii reopened this Nov 20, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on the top lbr_system_paramters.yaml should be replaced with lbr_system_config.yaml

Copy link
Member Author

@mhubii mhubii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good


void TwistController::configure_twist_impl_() {
twist_impl_ptr_ = std::make_unique<TwistImpl>(
this->get_robot_description(),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getting the robot description is not supported in humble

@mhubii
Copy link
Member Author

mhubii commented Nov 20, 2024

get_robot_description not available in humble

@mhubii mhubii closed this Nov 20, 2024
@mhubii mhubii deleted the dev-humble-rolling-backport branch November 20, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant