Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Fix #483: Unbind hangs in node v10 #485

Closed
wants to merge 5 commits into from
Closed

Fix #483: Unbind hangs in node v10 #485

wants to merge 5 commits into from

Conversation

jgeurts
Copy link

@jgeurts jgeurts commented Jul 9, 2018

Fixes #483

Seems that when the socket is connected and unbind is called with a callback parameter, the callback is not executed.

@jgeurts
Copy link
Author

jgeurts commented Jul 25, 2018

@joyent/node-ldapjs Is there anything else I can do to get this merged?

@jvanalst
Copy link

jvanalst commented Aug 2, 2018

Hmmm... failed tests. Darned.

@jgeurts
Copy link
Author

jgeurts commented Aug 3, 2018

The failed tests are unrelated to this fix, unless I’m mistaken

@jgeurts
Copy link
Author

jgeurts commented Oct 5, 2018

@melloc Can you please merge this and release an updated npm? This issue is preventing us from moving to node v10

@sunpeinju
Copy link

#497 maybe a safer replacement fix for this one. root cause of this issue has discussed with Node.js team (nodejs/node#24577), and #497 has passed ALL UTs on Node V10.

@jgeurts
Copy link
Author

jgeurts commented Mar 22, 2019

ldapts is a viable alternative to this library, that supports node v10+

@jsumners
Copy link
Member

@jgeurts I appreciate that you added tests to this PR. But the overall suite still fails on Node 10. Does this PR address a different issue from #497? Or do they both attempt to solve the same issue?

@jsumners
Copy link
Member

Thank you for contributing. I have merged #497 as the resolution. If you think that change did not address the same issue, or do so sufficiently, feel free to re-open.

@jsumners jsumners closed this Aug 27, 2019
@jsumners
Copy link
Member

⚠️ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.

Please include a minimal reproducible example
when opening a new issue.

@ldapjs ldapjs locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbind not working with node 10
4 participants