-
Notifications
You must be signed in to change notification settings - Fork 455
Conversation
@joyent/node-ldapjs Is there anything else I can do to get this merged? |
Hmmm... failed tests. Darned. |
The failed tests are unrelated to this fix, unless I’m mistaken |
@melloc Can you please merge this and release an updated npm? This issue is preventing us from moving to node v10 |
#497 maybe a safer replacement fix for this one. root cause of this issue has discussed with Node.js team (nodejs/node#24577), and #497 has passed ALL UTs on Node V10. |
ldapts is a viable alternative to this library, that supports node v10+ |
Thank you for contributing. I have merged #497 as the resolution. If you think that change did not address the same issue, or do so sufficiently, feel free to re-open. |
Please include a minimal reproducible example |
Fixes #483
Seems that when the socket is connected and unbind is called with a callback parameter, the callback is not executed.