This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Switch to rt.sections_elf_shared on Windows too #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
dll
branch
2 times, most recently
from
a5ae217 to
9d9e2b6
Compare
|
|
They have `extern(C)` linkage, but are defined in druntime (MSVCRT doesn't provide these symbols). Make them extern(D) to get exported with `-fvisibility=public`; Phobos unfortunately relies on the C names.
This works around the single remaining Phobos DLL linking error (somehow only required for debug Phobos), by replacing direct access to a little TLS buffer with a non-inlineable call to an accessor function (exported by druntime DLL and imported by other DLLs/executables instantiating the `staticError` template), on Windows in general. We cannot restrict this to `version(Shared)`, because that is set when compiling druntime, but what matters are `staticError` instantiations in other code.
We've already generalized that module for Apple Mach-O targets; with now added Windows support, it's an even bigger misnomer (should probably be `rt.sections_shared` instead). The point is to prepare for a shared druntime DLL, using the same _d_dso_registry() system. The module doesn't compile with `version(Shared)` just yet, that needs a bit more work; I've already replaced the pthread mutex by core.sync.mutex.Mutex etc. though. The new special `rt.dso_windows` module replaces the current compiler magic for Posix targets (emitting module ctor/dtor pair, CompilerDSOData struct etc. into each object file). It contains the code and data required _in each binary_ for proper registering and unregistering of binaries with/from druntime. It's linked in automatically with static druntime and the druntime DLL itself; the compiler needs to link it in automatically when linking a binary against shared druntime.
…he Phobos unittest DLL
kinke
force-pushed
the
dll
branch
2 times, most recently
from
23af7f6 to
d5053f6
Compare
…ons_win64 helpers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already generalized that module for Apple Mach-O targets; with now added Windows support, it's an even bigger misnomer (should probably be
rt.sections_sharedinstead).The point is to prepare for a shared druntime DLL, using the same
_d_dso_registry()system. The module doesn't compile withversion(Shared)just yet, that needs a bit more work; I've already replaced the pthread mutex bycore.sync.mutex.Mutexetc. though.The new special
rt.dso_windowsmodule replaces the current compiler magic for Posix targets (emitting module ctor/dtor pair,CompilerDSODatastruct etc. into each object file). It contains the code and data required in each binary for proper registering and unregistering of binaries with/from druntime. It's linked in automatically with static druntime and the druntime DLL itself; thecompiler needs to link it in automatically when linking a binary against shared druntime.