CMake: Support BUILD_SHARED_LIBS for Windows too #3704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinke
force-pushed
the
dll2
branch
3 times, most recently
from
c7677f3 to
5c271ef
Compare
|
The remaining Phobos linking errors aren't looking that bad: Edit: Updated. |
kinke
force-pushed
the
dll2
branch
3 times, most recently
from
0ba11e5 to
e97c87e
Compare
|
Okay, all linking errors are gone: |
|
Includes ldc-developers/druntime#197 now as well, i.e., using a generalized |
|
Looks like we're almost there:
The shared Phobos test runners represent a typical scenario: little .exe linked against 2 DLLs (druntime DLL and Phobos unittest DLL). It's also interesting because druntime is compiled all-at-once, while unittest-Phobos is compiled per-module; this affects Still TODO, OTOH:
|
kinke
force-pushed
the
dll2
branch
2 times, most recently
from
484fe58 to
4cf5b0c
Compare
kinke
force-pushed
the
dll2
branch
3 times, most recently
from
dc73d0d to
b0b8f49
Compare
By compiling druntime/Phobos with `-fvisibility=public` for the new DLLs. Compiling and linking druntime works fine: > ls -lh lib/druntime-ldc* -rwxr-xr-x 1 Martin 197121 2.4M Apr 24 19:28 lib/druntime-ldc-debug-shared.dll -rw-r--r-- 1 Martin 197121 2.9M Apr 24 19:28 lib/druntime-ldc-debug-shared.lib -rw-r--r-- 1 Martin 197121 12M Apr 24 19:28 lib/druntime-ldc-debug-shared.pdb -rw-r--r-- 1 Martin 197121 8.6M Apr 24 19:28 lib/druntime-ldc-debug.lib -rw-r--r-- 1 Martin 197121 4.7M Apr 24 19:28 lib/druntime-ldc-lto.lib -rwxr-xr-x 1 Martin 197121 2.2M Apr 24 19:28 lib/druntime-ldc-shared.dll -rw-r--r-- 1 Martin 197121 2.8M Apr 24 18:46 lib/druntime-ldc-shared.lib -rw-r--r-- 1 Martin 197121 8.5M Apr 24 19:28 lib/druntime-ldc-shared.pdb -rw-r--r-- 1 Martin 197121 4.4M Apr 24 19:28 lib/druntime-ldc.lib The druntime DLL exports more than 10k symbols. The MS C runtime is linked statically; that should probably be changed to the MS DLLs too. Linking a non-Phobos hello-world app against the druntime DLL works; it unsurprisingly crashes at runtime though. The Phobos DLL can be compiled too, but linking fails (builtin TypeInfo init symbols and vtables etc.).
And add oldnames.lib and legacy_stdio_definitions.lib for the Phobos DLL, which are linked automatically with static druntime via pragma(lib) directives.
…test runner executables
… the Phobos unittest DLL
…ry linked against shared druntime
…h -link-defaultlib-shared
…ny exports with -link-defaultlib-shared
|
Multiple identities for symbols across DLLs/executables aren't restricted to TypeInfos and templates, but include functions too: dlang/phobos#8110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By compiling druntime/Phobos with
-fvisibility=publicfor the new DLLs(=> #3703 included as prerequisite for now).Compiling and linking druntime works fine:
The druntime DLL exports more than 10k symbols.
The MS C runtime is linked statically; that should probably be changed to the MS DLLs too.Edit: done.Linking a non-Phobos hello-world app against the druntime DLL works; it unsurprisingly crashes at runtime though.
The Phobos DLL can be compiled too, but linking fails (builtin TypeInfo init symbols and vtables etc.).