Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise min LLVM version to 6.0 #3493

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Raise min LLVM version to 6.0 #3493

merged 1 commit into from
Jul 13, 2020

Conversation

kinke
Copy link
Member

@kinke kinke commented Jul 4, 2020

No description provided.

@kinke
Copy link
Member Author

kinke commented Jul 4, 2020

I wasn't really sure whether to raise to 5 or 6, but went with 6 in the end, mostly because most non-ancient distro versions ship with v6 or newer, see https://pkgs.org/download/llvm. E.g., Ubuntu jumped directly from v3.8 (16.04) to v6.0 (18.04), and Debian from v3.8 (stretch) to v7.0 (buster), so most users shouldn't be affected.

@dnadlinger
Copy link
Member

LLVM 6 was released in March 2018, so should be fine in that respect.

The only reason to hold off on this I can see would be if someone has a weird custom backend that is pre-6 only.

@JohanEngelen
Copy link
Member

The amount of code lines this removes is incredible.

@kinke
Copy link
Member Author

kinke commented Jul 5, 2020

Heh yeah, but most of it is just our version-specific profdata/FileCheck copies.

@kinke
Copy link
Member Author

kinke commented Jul 11, 2020

I've given the guys a week to respond to the forum thread, I think that's enough.

@kinke kinke merged commit 834f666 into ldc-developers:master Jul 13, 2020
@kinke kinke deleted the drop_old_llvm branch July 13, 2020 18:42
@Geod24
Copy link
Contributor

Geod24 commented Jul 14, 2020

This broke Buildkite: https://buildkite.com/dlang/dmd/builds/14258#2579093e-dd2a-478a-8ae0-ef6f30275231

Geod24 added a commit to Geod24/ldc that referenced this pull request Jul 14, 2020
@Geod24
Revert "Raise min LLVM version to 6.0 (ldc-developers#3493)"
b007923 
This reverts commit 834f666.
@Geod24 Geod24 mentioned this pull request Jul 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kinke @dnadlinger @JohanEngelen @Geod24