Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Raise min LLVM version to 6.0" #3507

Closed

Conversation

Geod24
Copy link
Contributor

@Geod24 Geod24 commented Jul 14, 2020

Reverts #3493

Because Buildkite needs to be updated: https://buildkite.com/dlang/dmd/builds/14258#2579093e-dd2a-478a-8ae0-ef6f30275231
You probably want to do something akin to: dlang/ci#317

@kinke
Copy link
Member

kinke commented Jul 14, 2020

You probably want to do

Not really. There's more than enough on my plate already, and I don't want to dive into the Buildkite details. Plus I'm not sure DMD's CI should depend on LDC master; AFAIK, most other projects use a tagged version (and that's been blocking some of my PRs).

@PetarKirov
Copy link
Contributor

It's a good practice to always test the bleeding edge, though such builds should be allowed to fail.

@kinke
Copy link
Member

kinke commented Jul 14, 2020

Stuff to figure out for the upstream CI. AFAICT, testing LDC, i.e., building LDC with the fresh DMD, is mostly useful to catch C++ interop regressions; for that, using LDC master isn't really needed.

Anyway, I'm definitely not accepting the revert as a band-aid for the DMD CI regression.

@Geod24
Copy link
Contributor Author

Geod24 commented Jul 14, 2020

Then could someone raise a PR to either use a tag or drop LDC? I'd do it if I was not on a phone.

@kinke
Copy link
Member

kinke commented Jul 14, 2020

Proposed band-aid: dlang/ci#420

@kinke kinke closed this Jul 14, 2020
@dnadlinger
Copy link
Member

See dlang/ci#421 – bumping the LLVM version shouldn't be hard, but I don't have the setup to easily test the changes myself right now.

@Geod24 Geod24 deleted the revert-3493-drop_old_llvm branch July 14, 2020 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants