Default to rv64gc on riscv64 [slightly revised] #4474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also select the correct ABI by default matching the enabled features (double, float or no floating point). Fixes ldc-developers#4375
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
|
|
|||
| #### Platform support | |||
| - Supports LLVM 11.0 - 16.0. | |||
| - When nothing else specified now defaults to `-mattr=+m,+a,+f,+d,+c` when targeting hosted 64-bit RISC-V. (#4390) | |||
There was a problem hiding this comment.
for me the term "hosted" is new in this context (with "host" and "target" I'm thinking about the "host" system that compiles a program for use on another "target" system). Is it better to explicitly say for triples with an OS that is not "unknown" or "none" ?
There was a problem hiding this comment.
It was new to me too. - I hope it's somewhat more understandable now.
There was a problem hiding this comment.
Hosted is the opposite of freestanding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly revised #4390.