Added automaticInitialCoverScale #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maraujop
added a commit
to maraujop/react-native-view-transformer
that referenced
this pull request
Aug 31, 2016
Sets the initial scale to be used, and allow cover mode to work in react-native-transformable-image ldn0x7dc/react-native-transformable-image#11
When this prop is activated the image is rendered like if `resizeMode` was set to `cover`. * It takes into account screen density * Recalculate when source changes (this can happen when reusing a not yet unmounted component). Point to view-transformer branch with applyLimits feature
maraujop
force-pushed
the
feature-automaticInitialCoverScale
branch
from
fcca330
to
c9ba129
Compare
This way until image is loaded pan responders are available and prevent crashing if they are expected to exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this case I needed my images to behave like if their resizeMode was set to
coverand to be honest, if you agree, instead of adding a new prop likeautomaticInitialCoverScaleI think it would be better to makeresizeModework, as that's the one people would expect to change in the original Image component and they already understand it.When this prop is activated the image is rendered like if
resizeModewas set tocover.This PR also allows to use
enableLimitsfrom this other PR ldn0x7dc/react-native-view-transformer#5 and it also relies oninitialScaleprop from that PR to work. I could make them non dependent if you want me to.Maybe it would be nice to pass <ViewTransformer {...this.props}> too, so that it would not be necessary to make PRs dependent.
Thanks, cheers
Miguel