Added feature enableLimits #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Activating this prop, the view cannot be moved out of viewport. This is the typical default behavior in any native photoview library.
Sets the initial scale to be used, and allow cover mode to work in react-native-transformable-image ldn0x7dc/react-native-transformable-image#11
maraujop
force-pushed
the
feature-enableLimits
branch
from
fdcf55c
to
6bcc35d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ldn0x7dc
First thanks for this project and also
react-native-transformable-image, they are both incredible. I've been modifying some parts of both libraries and I'm going to submit some PRs with what I think could be useful to everyone out there. I want to first say that the code of both libraries is super clean and easy to follow, you've done an amazing work.This PR adds a prop called
enableLimitsActivating this prop, the view cannot be moved out of its viewport. This is the typical default behavior in any Android native photoview library.I'm using this in my personal project, because I wanted transformable-image to behave the closest possible to other native libraries.
Thanks, cheers
Miguel