Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gaming language from README #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JeffHoover
Copy link
Collaborator

No description provided.

goblin in the corner who will insta-rage and one-shot you as he doesn't believe in shared code
ownership (you can make the UpdateQuality method and Items property static if you like, we'll cover
for you).
still works correctly. However, do not alter the Item class or Items property as those belong to a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn’t make sense in the full context of the requirements section, IMO. The entire README is written around a story that we’re a team working at an inn that buys and sells “only the finest goods”.

If the intent is to remove the story around being an inn that sells items in a fictional world, we’ll want to change the readme more holistically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely not advocating removing the story at this time, and I think a lot more than the README would have to change to accomplish that, were we ever to make that a goal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what bothers me is that the README has what feels like two contexts for someone to grasp: the inn/goods context is D&D/fantasy and the insta-rage / one-shot context feels additionally like gamer culture, (and the rest of the kata only relies on the first context). Would the following edit hold true to the story?
... goblin in the corner who will destroy you as he doesn't believe in ...
I guess of "insta-rage" and "one-shot". the latter feels the most like adding a superfluous second context. I'd also be open to:
... goblin in the corner who will insta-rage and destroy you as he doesn't believe in ...

Copy link
Contributor

@walterg2 walterg2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the comment left, I don't think this change makes the file read any better, nor does it keep the information consistent. Let's talk about the reasons behind removing the fictional language as a whole and see what may work better in its place.

@rdammkoehler
Copy link

I don't know why I have access to this repo; but I think the fictional language is fine and I don't understand why it should be changed either.

@walterg2
Copy link
Contributor

I don't know why I have access to this repo; but I think the fictional language is fine and I don't understand why it should be changed either.

@rdammkoehler - This is a public repo that, I'd bet, you're listed as watching. That's probably true for a few other repos that are public as well.

@butchhoward
Copy link
Contributor

butchhoward commented Apr 18, 2022

  • I would not mind having the entire story/instructions re-written to get rid of all the silliness. I am not bothered by the silliness itself so much, but by the way it distracts from giving the guidance to what we want someone to accomplish with this exercise.

  • On the other hand, since we are using this as a step to pointing them toward the Bache repo, which will continue to contain the silliness, I do not see much point in making any changes here.

  • On the gripping hand, maybe having our own, clear, no-silliness instructions as a compliment to the Bache instructions would be useful (but maybe not, could be even more confusing having two sets like that).

  • So, that leaves me back at not changing it.

@JeffHoover
Copy link
Collaborator Author

... but I think the fictional language is fine and I don't understand why it should be changed either.

Here's where my hesitance about the language comes from: the fictional language as it is written presupposes a certain set of cultural experiences - dungeons & dragons, fantasy fiction, gaming. Those aren't experiences that I want to filter on, so, if it were easy, I'd want to replace the language with something more universal. In my mind, more universal allows for the broadest set of good candidates.
Also, I aim to offer a comfortable pairing interview. It enables the interviewee to do their best, and it leaves them with a good impression of the company, even if they don't receive an offer. I've had candidates for whom the fictional context wasn't natural, and they started the exercise a little "off balance". It didn't change the outcome of the interview, and I'm sure nobody ever left a bad review on Glassdoor as a result of it, but if were an easy optimization, I would make it. I can imagine that some candidates that I'd be happy to hire, say who are from other countries, could have a harder time.

I wish there was a refactoring kata which was available in many languages that used a more universal fictional context. AFAIK there isn't. This conversation is as valuable to me as the decision of whether or not to change one phrase in one README.

@rdammkoehler
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants