-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove gaming language from README #2
base: main
Are you sure you want to change the base?
Conversation
goblin in the corner who will insta-rage and one-shot you as he doesn't believe in shared code | ||
ownership (you can make the UpdateQuality method and Items property static if you like, we'll cover | ||
for you). | ||
still works correctly. However, do not alter the Item class or Items property as those belong to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn’t make sense in the full context of the requirements section, IMO. The entire README is written around a story that we’re a team working at an inn that buys and sells “only the finest goods”.
If the intent is to remove the story around being an inn that sells items in a fictional world, we’ll want to change the readme more holistically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm definitely not advocating removing the story at this time, and I think a lot more than the README would have to change to accomplish that, were we ever to make that a goal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess what bothers me is that the README has what feels like two contexts for someone to grasp: the inn/goods context is D&D/fantasy and the insta-rage / one-shot context feels additionally like gamer culture, (and the rest of the kata only relies on the first context). Would the following edit hold true to the story?
... goblin in the corner who will destroy you as he doesn't believe in ...
I guess of "insta-rage" and "one-shot". the latter feels the most like adding a superfluous second context. I'd also be open to:
... goblin in the corner who will insta-rage and destroy you as he doesn't believe in ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the comment left, I don't think this change makes the file read any better, nor does it keep the information consistent. Let's talk about the reasons behind removing the fictional language as a whole and see what may work better in its place.
I don't know why I have access to this repo; but I think the fictional language is fine and I don't understand why it should be changed either. |
@rdammkoehler - This is a public repo that, I'd bet, you're listed as watching. That's probably true for a few other repos that are public as well. |
|
Here's where my hesitance about the language comes from: the fictional language as it is written presupposes a certain set of cultural experiences - dungeons & dragons, fantasy fiction, gaming. Those aren't experiences that I want to filter on, so, if it were easy, I'd want to replace the language with something more universal. In my mind, more universal allows for the broadest set of good candidates. I wish there was a refactoring kata which was available in many languages that used a more universal fictional context. AFAIK there isn't. This conversation is as valuable to me as the decision of whether or not to change one phrase in one README. |
@JeffHoover could I suggest this one? https://github.com/emilybache/Tennis-Refactoring-Kata |
No description provided.