Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove gaming language from README #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove gaming language from README #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,9 @@ We have recently signed a supplier of conjured items. This requires an update to
- "Conjured" items degrade in Quality twice as fast as normal items

Feel free to make any changes to the UpdateQuality method and add any new code as long as everything
still works correctly. However, do not alter the Item class or Items property as those belong to the
goblin in the corner who will insta-rage and one-shot you as he doesn't believe in shared code
ownership (you can make the UpdateQuality method and Items property static if you like, we'll cover
for you).
still works correctly. However, do not alter the Item class or Items property as those belong to a
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn’t make sense in the full context of the requirements section, IMO. The entire README is written around a story that we’re a team working at an inn that buys and sells “only the finest goods”.

If the intent is to remove the story around being an inn that sells items in a fictional world, we’ll want to change the readme more holistically.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm definitely not advocating removing the story at this time, and I think a lot more than the README would have to change to accomplish that, were we ever to make that a goal.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess what bothers me is that the README has what feels like two contexts for someone to grasp: the inn/goods context is D&D/fantasy and the insta-rage / one-shot context feels additionally like gamer culture, (and the rest of the kata only relies on the first context). Would the following edit hold true to the story?
... goblin in the corner who will destroy you as he doesn't believe in ...
I guess of "insta-rage" and "one-shot". the latter feels the most like adding a superfluous second context. I'd also be open to:
... goblin in the corner who will insta-rage and destroy you as he doesn't believe in ...

very possesive developer who doesn't believe in shared code ownership (you can make the UpdateQuality
method and Items property static if you like, we'll cover for you).

This is a sample problem, but we want you to treat this like production code.
We want to see how you work with production code as this is a core part of the work we do.
Expand Down