Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle SIGBUS when looking for stack overflows #4971

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

david-christiansen
Copy link
Contributor

@david-christiansen david-christiansen commented Aug 9, 2024

Without this change, a stack overflow on Mac OS during tactic execution can lead to the message:

terminated by signal SIGBUS (Misaligned address error)

This comes from lean_alloc_small. With the change, the process instead terminates with the more accurate and actionable:

Stack overflow detected. Aborting.

Without this change, a stack overflow on Mac OS during tactic
execution can lead to the message:

terminated by signal SIGBUS (Misaligned address error)

This comes from the `lean_alloc_small`. With the change, the process
instead terminates with the more accurate and actionable:

Stack overflow detected. Aborting.
@david-christiansen david-christiansen added the release-ci Enable all CI checks for a PR, like is done for releases label Aug 9, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 9, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 88a7f5c59248cd63570ccedd083ce726f659e9b8 --onto dd6ed124baef64a26ef5860f49597fdcef371239. (2024-08-09 12:01:27)

@david-christiansen david-christiansen added the will-merge-soon …unless someone speaks up label Aug 12, 2024
@Kha Kha added this pull request to the merge queue Aug 12, 2024
Merged via the queue into leanprover:master with commit ecd3aa4 Aug 12, 2024
26 checks passed
github-merge-queue bot pushed a commit that referenced this pull request Aug 19, 2024
Such handlers can come from address sanitizers and similar. When
combined with #4971, this forward-ports
rust-lang/rust@676b9bc
/ rust-lang/rust#69685

---------

Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants