Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Do not overwrite existing signal handlers #5062

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix: Do not overwrite existing signal handlers #5062

merged 2 commits into from
Aug 19, 2024

Conversation

eric-wieser
Copy link
Contributor

@eric-wieser eric-wieser commented Aug 15, 2024 •
edited
Loading

Such handlers can come from address sanitizers and similar. When combined with #4971, this forward-ports rust-lang/rust@676b9bc / rust-lang/rust#69685

@eric-wieser
fix: Do not overwrite existing signal handlers
0b65607 
Such handlers can come from address sanitizers and similar.
This forward-ports rust-lang/rust@676b9bc.
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 15, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Aug 15, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-08-15 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-08-15 18:45:25)
  • ✅ Mathlib branch lean-pr-testing-5062 has successfully built against this PR. (2024-08-16 11:26:29) View Log

Kha
Kha reviewed Aug 16, 2024
View reviewed changes
src/runtime/stack_overflow.cpp Outdated Show resolved Hide resolved
@eric-wieser @Kha
Update src/runtime/stack_overflow.cpp
51dfd11 
Co-authored-by: Sebastian Ullrich <sebasti@nullri.ch>
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Aug 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5062
e9328b8
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Aug 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5062
2745eb4
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Aug 16, 2024
@leanprover-bot leanprover-bot added the P-high We will work on this issue label Aug 16, 2024
@Kha Kha added this pull request to the merge queue Aug 19, 2024
Merged via the queue into leanprover:master with commit f2573dc Aug 19, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kha Kha Kha left review comments

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR P-high We will work on this issue toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eric-wieser @leanprover-community-mathlib4-bot @Kha @leanprover-bot