-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Pdf Viewer plugin #11328
Comments
I would like to work on it. |
@ShivangRawat30 I already assigned you some other issues so I'll leave this open for other contributors. You're welcome to remind yourself here again as soon as you've finished them (explained more in one of the comments I left for you). |
I've opened a PR related to the other assigned issues, can I work on this issue ? |
Yes, thank you @ShivangRawat30 |
is this closed or not? if not I would like to work on it |
Hi, @mhdsalih2000, thanks for volunteering! We have already received a pull request for this issue which will be merged soon. You're welcome to choose another issue. We currently have contributing opportunities in three repositories. You can see the contributing guidelines (including links to issues suitable for contribution) for each of them here: Kolibri: https://github.com/learningequality/kolibri/blob/release-v0.16.x/CONTRIBUTING.md |
changed KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin
Closed by #11529 |
This is one of the issues whose common goal is to gradually replace
KResponsiveWindow
mixin byuseKResponsiveWindow
composable.First, see #11321 for detailed instructions and acceptance criteria common to all issues.
Then, replace
KResponsiveWindow
mixin byuseKResponsiveWindow
composable in all .vue files of the Pdf Viewer plugin (/kolibri/plugins/pdf_viewer)The text was updated successfully, but these errors were encountered: