Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace KResponsiveWindow mixin by useKResponsiveWindow composable - Pdf Viewer plugin #11328

Closed
Tracked by #11321
MisRob opened this issue Sep 29, 2023 · 7 comments
Closed
Tracked by #11321
Assignees
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have

Comments

@MisRob
Copy link
Contributor

MisRob commented Sep 29, 2023

This is one of the issues whose common goal is to gradually replace KResponsiveWindow mixin by useKResponsiveWindow composable.

First, see #11321 for detailed instructions and acceptance criteria common to all issues.

Then, replace KResponsiveWindow mixin by useKResponsiveWindow composable in all .vue files of the Pdf Viewer plugin (/kolibri/plugins/pdf_viewer)

@MisRob MisRob added P2 - normal Priority: Nice to have DEV: frontend help wanted Open source contributors welcome good first issue Self-contained, straightforward, low-complexity labels Sep 29, 2023
@ShivangRawat30
Copy link
Contributor

I would like to work on it.

@MisRob
Copy link
Contributor Author

MisRob commented Oct 2, 2023

@ShivangRawat30 I already assigned you some other issues so I'll leave this open for other contributors. You're welcome to remind yourself here again as soon as you've finished them (explained more in one of the comments I left for you).

@ShivangRawat30
Copy link
Contributor

I've opened a PR related to the other assigned issues, can I work on this issue ?

@MisRob
Copy link
Contributor Author

MisRob commented Oct 10, 2023

Yes, thank you @ShivangRawat30

@mhdsalih2000
Copy link

is this closed or not? if not I would like to work on it

@MisRob
Copy link
Contributor Author

MisRob commented Nov 20, 2023

Hi, @mhdsalih2000, thanks for volunteering! We have already received a pull request for this issue which will be merged soon. You're welcome to choose another issue.

We currently have contributing opportunities in three repositories. You can see the contributing guidelines (including links to issues suitable for contribution) for each of them here:

Kolibri: https://github.com/learningequality/kolibri/blob/release-v0.16.x/CONTRIBUTING.md
Kolibri Design System: https://github.com/learningequality/kolibri-design-system/blob/main/CONTRIBUTING.md
Studio: https://github.com/learningequality/studio (the contributing guidelines are not ready yet here, but you could find issues in the same manner like for the other two repositories)

MisRob added a commit that referenced this issue Nov 22, 2023
changed KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin
@MisRob
Copy link
Contributor Author

MisRob commented Nov 22, 2023

Closed by #11529

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend good first issue Self-contained, straightforward, low-complexity help wanted Open source contributors welcome P2 - normal Priority: Nice to have
Projects
None yet
Development

No branches or pull requests

5 participants