Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin #11529

Merged
merged 3 commits into from
Nov 22, 2023

Conversation

ShivangRawat30
Copy link
Contributor

Summary

This PR changes the KResponsiveWindow to useKResponsiveWindow in Pdf Viewer plugin

References

#11328

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Signed-off-by: shivangrawat30 <rawatshivang30@gmail.com>
Signed-off-by: shivangrawat30 <rawatshivang30@gmail.com>
@MisRob MisRob self-requested a review November 15, 2023 08:57
@MisRob MisRob added the TODO: needs review Waiting for review label Nov 15, 2023
Copy link
Contributor

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ShivangRawat30, this is great work and thanks for yet another contribution! We left one minor note that would be nice to resolve. Could you also please fix linting? The check is failing.

Signed-off-by: shivangrawat30 <rawatshivang30@gmail.com>
Copy link
Contributor

@MisRob MisRob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @ShivangRawat30, all good. When testing manually, I observed no problems.

@MisRob MisRob merged commit 4de6c2f into learningequality:develop Nov 22, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants