Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EQM - Preview quiz - The selection effect is reversed #12425

Closed
pcenov opened this issue Jul 8, 2024 · 3 comments · Fixed by #12427 or #12920
Closed

EQM - Preview quiz - The selection effect is reversed #12425

pcenov opened this issue Jul 8, 2024 · 3 comments · Fixed by #12427 or #12920
Assignees
@nucleogenesis
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Milestone
Kolibri 0.18: Coa...

Comments

@pcenov
Copy link
Member

pcenov commented Jul 8, 2024

Observed behavior

See the screenshot.

Screenshot:

selection

Expected behavior

Only the currently selected question should be highlighted in light gray.

Steps to reproduce the issue

  1. Install the build from https://github.com/learningequality/kolibri/releases/tag/v0.17.0-beta0
  2. Create a new quiz with sections and save it.
  3. While at Coach > Quizzes click on the title of the quiz.

Usage Details

Windows 11, Ubuntu 22 - Chrome
@pcenov
Copy link
Member Author

pcenov commented Jul 8, 2024

@radinamatic

@radinamatic radinamatic added bug Behavior is wrong or broken P0 - critical Priority: Release blocker or regression APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jul 8, 2024
@nucleogenesis
Copy link
Member

For any dev who takes this -- the background is currently falling back to or is transparent so that the underlying elements are shown except for the active one, which is made white. So it seems like perhaps this is as simple as flipping those two values 🤞

@MisRob MisRob mentioned this issue Jul 8, 2024
Merged
9 tasks
nathanaelg16 pushed a commit to nathanaelg16/kolibri that referenced this issue Aug 8, 2024
@MisRob @nathanaelg16
Fix colors of list items
8481053 
and remove hardcoded colors
in favor of theme tokens.

Fixes learningequality#12425
@MisRob MisRob removed their assignment Dec 2, 2024
@MisRob
Copy link
Contributor

MisRob commented Dec 2, 2024

Re-opening since it seems we somehow lost the fix #12427 as reported by @pcenov here

@MisRob MisRob reopened this Dec 2, 2024
@nucleogenesis nucleogenesis mentioned this issue Dec 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nucleogenesis nucleogenesis

Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) bug Behavior is wrong or broken DEV: frontend P0 - critical Priority: Release blocker or regression
Projects
None yet
Milestone
Kolibri 0.18: Coach Resource Discovery
5 participants
@radinamatic @rtibbles @nucleogenesis @MisRob @pcenov