Coach questions preview: Fix background and selection colors + resolve linter errors #12427
Conversation
and remove hardcoded colors in favor of theme tokens. Fixes learningequality#12425
This fixes vue/require-v-for-key 'Elements in iteration expect to have 'v-bind:key' directives.' lint error and ensures efficient Vue updates.
github-actions
bot
added
APP: Coach
MisRob
requested review from
nucleogenesis,
AllanOXDi and
pcenov
and removed request for
pcenov
Build Artifacts
|
MisRob
changed the title
There was a problem hiding this comment.
Code changes LGTM - thanks Misha! I added @pcenov as a reviewer here to get his thoughts on the updates and if this sufficiently addresses the related issue
|
|
||
| &:hover { | ||
| background-color: white; | ||
| } | ||
|
|
||
| &.selected { | ||
| background-color: white; | ||
| } |
There was a problem hiding this comment.
I did this in a bit of a rush 😅 - thanks for the reminder on $computedClass 😃
|
Hi @nucleogenesis I noticed that this fix is not in https://github.com/learningequality/kolibri/releases/tag/v0.17.0-beta2 - could you check why? Thanks! |
|
As far as I can see the fix is present in 0.17b3, so we should be good 🙂 
|
|
Hi @radinamatic and @nucleogenesis - the fix is still not present in 0.17.0-rc2: 2024-08-02_16-12-27.mp4 |
|
@MisRob and @nucleogenesis - for some reason this is still not merged even in https://github.com/learningequality/kolibri/releases/tag/v0.18.0-alpha0 - could you investigate why is this the case? 2024-11-29_15-16-11.mp4 |
Summary
After (see the linked issue for 'before')
References
Closes #12425
Reviewer guidance
Preview a quiz with several questions as a coach in Plan.
Testing checklist
Critical user journeys are covered by Gherkin storiesCritical and brittle code paths are covered by unit testsPR process
If this is an important user-facing change, PR or related issue has a 'changelog' labelIf this includes an internal dependency change, a link to the diff is providedReviewer checklist
yarnandpip)