-
Notifications
You must be signed in to change notification settings - Fork 699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
number of resources updates on selection #11825
Merged
AllanOXDi
merged 10 commits into
learningequality:develop
from
AllanOXDi:display_number_of_selected_resources
Feb 9, 2024
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a8349c3
number of resources updates on selection
AllanOXDi 6ea994a
added function to render the number of resources in the folder
AllanOXDi 609c307
get exercise counts -- and make sure channels are treated as topics f…
nucleogenesis cc1c2aa
displays proper count
AllanOXDi b20ee86
displays proper count
AllanOXDi 91f6ed0
cleanup console.log
AllanOXDi 72effa5
Remove side-effects code from the isSelectAllChecked computed prop
AllanOXDi acf1949
code cleanup
AllanOXDi 30a9341
number of selected execrises display correctly per topic
AllanOXDi ffee918
can deselect exercises from the working resource pool
AllanOXDi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the setting of
isSelectAllChecked
here is good as it's a computed property.In my note on that
isSelectAllChecked
property I mentioned that the side-effects of manipulating the working resource pool should probably be moved here.In the
else
block here, however, rather thanresetWorkingResourcePool
this should instead remove all items in the content list from the working resource pool.resetWorkingResourcePool
just undoes all changes the user has made since opening the panel, which is not desired here.In this case, you'd need to do a
this.contentList.forEach(content => this.removeFromWorkingResourcePool(content))
(or something along those lines -- you'll probably also want to be sure to filter out Topics as we aren't permitting full topic selection until #11790 is implemented)